Skip to content

Commit 8e21d5b

Browse files
chris-olszewskichris-olszewski
authored
chore(ci): use mise for installing protoc (#1382)
* chore(ci): use mise for installing protoc * explicitly set PROTOC
1 parent 9b9325c commit 8e21d5b

3 files changed

Lines changed: 62 additions & 49 deletions

File tree

‎.github/workflows/heavy.yml‎

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,11 @@ jobs:
2424
with:
2525
submodules: recursive
2626
- uses: dtolnay/rust-toolchain@29eef336d9b2848a0b548edc03f92a220660cdb8 # stable
27-
- name: Install protoc
28-
uses: arduino/setup-protoc@c65c819552d16ad3c9b72d9dfd5ba5237b9c906b # v3
27+
- name: Run mise install
28+
uses: jdx/mise-action@e6a8b3978addb5a52f2b4cd9d91eafa7f0ab959d # v4.2.0
2929
with:
30-
# TODO: Upgrade proto once https://github.com/arduino/setup-protoc/issues/99 is fixed
31-
version: "23.x"
32-
repo-token: ${{ secrets.GITHUB_TOKEN }}
30+
version: 2026.7.1
31+
- name: Set PROTOC
32+
shell: bash
33+
run: printf 'PROTOC=%s\n' "$(mise which protoc)" >> "$GITHUB_ENV"
3334
- run: cargo integ-test -c "--release" -t heavy_tests -- --test-threads 1

‎.github/workflows/per-pr.yml‎

Lines changed: 54 additions & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -24,12 +24,13 @@ jobs:
2424
with:
2525
submodules: recursive
2626
- uses: dtolnay/rust-toolchain@29eef336d9b2848a0b548edc03f92a220660cdb8 # stable
27-
- name: Install protoc
28-
uses: arduino/setup-protoc@c65c819552d16ad3c9b72d9dfd5ba5237b9c906b # v3
27+
- name: Run mise install
28+
uses: jdx/mise-action@e6a8b3978addb5a52f2b4cd9d91eafa7f0ab959d # v4.2.0
2929
with:
30-
# TODO: Upgrade proto once https://github.com/arduino/setup-protoc/issues/99 is fixed
31-
version: "23.x"
32-
repo-token: ${{ secrets.GITHUB_TOKEN }}
30+
version: 2026.7.1
31+
- name: Set PROTOC
32+
shell: bash
33+
run: printf 'PROTOC=%s\n' "$(mise which protoc)" >> "$GITHUB_ENV"
3334
- run: rustup component add rustfmt clippy
3435
- uses: Swatinem/rust-cache@e18b497796c12c097a38f9edb9d0641fb99eee32 # v2
3536
with:
@@ -67,12 +68,13 @@ jobs:
6768
steps:
6869
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
6970
- uses: dtolnay/rust-toolchain@29eef336d9b2848a0b548edc03f92a220660cdb8 # stable
70-
- name: Install protoc
71-
uses: arduino/setup-protoc@c65c819552d16ad3c9b72d9dfd5ba5237b9c906b # v3
71+
- name: Run mise install
72+
uses: jdx/mise-action@e6a8b3978addb5a52f2b4cd9d91eafa7f0ab959d # v4.2.0
7273
with:
73-
# TODO: Upgrade proto once https://github.com/arduino/setup-protoc/issues/99 is fixed
74-
version: "23.x"
75-
repo-token: ${{ secrets.GITHUB_TOKEN }}
74+
version: 2026.7.1
75+
- name: Set PROTOC
76+
shell: bash
77+
run: printf 'PROTOC=%s\n' "$(mise which protoc)" >> "$GITHUB_ENV"
7678
# Workaround for https://github.com/actions/runner-images/issues/12432
7779
# from https://github.com/rust-lang/rust/issues/141626#issuecomment-2919419236
7880
# Visual Studio bug tracker https://developercommunity.visualstudio.com/t/Regression-from-1943:-linkexe-crashes/10912960
@@ -117,12 +119,13 @@ jobs:
117119
with:
118120
submodules: recursive
119121
- uses: dtolnay/rust-toolchain@29eef336d9b2848a0b548edc03f92a220660cdb8 # stable
120-
- name: Install protoc
121-
uses: arduino/setup-protoc@c65c819552d16ad3c9b72d9dfd5ba5237b9c906b # v3
122+
- name: Run mise install
123+
uses: jdx/mise-action@e6a8b3978addb5a52f2b4cd9d91eafa7f0ab959d # v4.2.0
122124
with:
123-
# TODO: Upgrade proto once https://github.com/arduino/setup-protoc/issues/99 is fixed
124-
version: "23.x"
125-
repo-token: ${{ secrets.GITHUB_TOKEN }}
125+
version: 2026.7.1
126+
- name: Set PROTOC
127+
shell: bash
128+
run: printf 'PROTOC=%s\n' "$(mise which protoc)" >> "$GITHUB_ENV"
126129
- run: rustup component add rustfmt clippy
127130
- uses: Swatinem/rust-cache@e18b497796c12c097a38f9edb9d0641fb99eee32 # v2
128131
with:
@@ -173,12 +176,13 @@ jobs:
173176
steps:
174177
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
175178
- uses: dtolnay/rust-toolchain@29eef336d9b2848a0b548edc03f92a220660cdb8 # stable
176-
- name: Install protoc
177-
uses: arduino/setup-protoc@c65c819552d16ad3c9b72d9dfd5ba5237b9c906b # v3
179+
- name: Run mise install
180+
uses: jdx/mise-action@e6a8b3978addb5a52f2b4cd9d91eafa7f0ab959d # v4.2.0
178181
with:
179-
# TODO: Upgrade proto once https://github.com/arduino/setup-protoc/issues/99 is fixed
180-
version: "23.x"
181-
repo-token: ${{ secrets.GITHUB_TOKEN }}
182+
version: 2026.7.1
183+
- name: Set PROTOC
184+
shell: bash
185+
run: printf 'PROTOC=%s\n' "$(mise which protoc)" >> "$GITHUB_ENV"
182186
# Workaround for https://github.com/actions/runner-images/issues/12432
183187
# from https://github.com/rust-lang/rust/issues/141626#issuecomment-2919419236
184188
# Visual Studio bug tracker https://developercommunity.visualstudio.com/t/Regression-from-1943:-linkexe-crashes/10912960
@@ -204,12 +208,13 @@ jobs:
204208
- name: Install WASM Rust targets
205209
# Install after checkout so rustup uses this repo's rust-toolchain.toml override.
206210
run: rustup target add wasm32-unknown-unknown wasm32-wasip1
207-
- name: Install protoc
208-
uses: arduino/setup-protoc@c65c819552d16ad3c9b72d9dfd5ba5237b9c906b # v3
211+
- name: Run mise install
212+
uses: jdx/mise-action@e6a8b3978addb5a52f2b4cd9d91eafa7f0ab959d # v4.2.0
209213
with:
210-
# TODO: Upgrade proto once https://github.com/arduino/setup-protoc/issues/99 is fixed
211-
version: "23.x"
212-
repo-token: ${{ secrets.GITHUB_TOKEN }}
214+
version: 2026.7.1
215+
- name: Set PROTOC
216+
shell: bash
217+
run: printf 'PROTOC=%s\n' "$(mise which protoc)" >> "$GITHUB_ENV"
213218
- uses: Swatinem/rust-cache@e18b497796c12c097a38f9edb9d0641fb99eee32 # v2
214219
with:
215220
save-if: ${{ github.ref == 'refs/heads/main' }}
@@ -231,12 +236,13 @@ jobs:
231236
steps:
232237
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
233238
- uses: dtolnay/rust-toolchain@29eef336d9b2848a0b548edc03f92a220660cdb8 # stable
234-
- name: Install protoc
235-
uses: arduino/setup-protoc@c65c819552d16ad3c9b72d9dfd5ba5237b9c906b # v3
239+
- name: Run mise install
240+
uses: jdx/mise-action@e6a8b3978addb5a52f2b4cd9d91eafa7f0ab959d # v4.2.0
236241
with:
237-
# TODO: Upgrade proto once https://github.com/arduino/setup-protoc/issues/99 is fixed
238-
version: "23.x"
239-
repo-token: ${{ secrets.GITHUB_TOKEN }}
242+
version: 2026.7.1
243+
- name: Set PROTOC
244+
shell: bash
245+
run: printf 'PROTOC=%s\n' "$(mise which protoc)" >> "$GITHUB_ENV"
240246

241247
- uses: Swatinem/rust-cache@e18b497796c12c097a38f9edb9d0641fb99eee32 # v2
242248
with:
@@ -257,12 +263,13 @@ jobs:
257263
steps:
258264
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
259265
- uses: dtolnay/rust-toolchain@29eef336d9b2848a0b548edc03f92a220660cdb8 # stable
260-
- name: Install protoc
261-
uses: arduino/setup-protoc@c65c819552d16ad3c9b72d9dfd5ba5237b9c906b # v3
266+
- name: Run mise install
267+
uses: jdx/mise-action@e6a8b3978addb5a52f2b4cd9d91eafa7f0ab959d # v4.2.0
262268
with:
263-
# TODO: Upgrade proto once https://github.com/arduino/setup-protoc/issues/99 is fixed
264-
version: "23.x"
265-
repo-token: ${{ secrets.GITHUB_TOKEN }}
269+
version: 2026.7.1
270+
- name: Set PROTOC
271+
shell: bash
272+
run: printf 'PROTOC=%s\n' "$(mise which protoc)" >> "$GITHUB_ENV"
266273
- name: Start container for otel-collector and prometheus
267274
uses: hoverkraft-tech/compose-action@4894d2492015c1774ee5a13a95b1072093087ec3 # v2.5.0
268275
with:
@@ -280,11 +287,13 @@ jobs:
280287
steps:
281288
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
282289
- uses: dtolnay/rust-toolchain@29eef336d9b2848a0b548edc03f92a220660cdb8 # stable
283-
- name: Install protoc
284-
uses: arduino/setup-protoc@c65c819552d16ad3c9b72d9dfd5ba5237b9c906b # v3
290+
- name: Run mise install
291+
uses: jdx/mise-action@e6a8b3978addb5a52f2b4cd9d91eafa7f0ab959d # v4.2.0
285292
with:
286-
version: "23.x"
287-
repo-token: ${{ secrets.GITHUB_TOKEN }}
293+
version: 2026.7.1
294+
- name: Set PROTOC
295+
shell: bash
296+
run: printf 'PROTOC=%s\n' "$(mise which protoc)" >> "$GITHUB_ENV"
288297
- uses: Swatinem/rust-cache@e18b497796c12c097a38f9edb9d0641fb99eee32 # v2
289298
with:
290299
cache-bin: false
@@ -308,12 +317,13 @@ jobs:
308317
steps:
309318
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
310319
- uses: dtolnay/rust-toolchain@29eef336d9b2848a0b548edc03f92a220660cdb8 # stable
311-
- name: Install protoc
312-
uses: arduino/setup-protoc@c65c819552d16ad3c9b72d9dfd5ba5237b9c906b # v3
320+
- name: Run mise install
321+
uses: jdx/mise-action@e6a8b3978addb5a52f2b4cd9d91eafa7f0ab959d # v4.2.0
313322
with:
314-
# TODO: Upgrade proto once https://github.com/arduino/setup-protoc/issues/99 is fixed
315-
version: "23.x"
316-
repo-token: ${{ secrets.GITHUB_TOKEN }}
323+
version: 2026.7.1
324+
- name: Set PROTOC
325+
shell: bash
326+
run: printf 'PROTOC=%s\n' "$(mise which protoc)" >> "$GITHUB_ENV"
317327

318328
- name: Build crate as static library
319329
run: cargo rustc --package temporalio-sdk-core-c-bridge --features xz2-static -- --crate-type=staticlib

‎mise.toml‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
[tools]
2+
protoc = "23.4"

0 commit comments

Comments
 (0)