Skip to content

Commit 97f7301

Browse files
committed
dram: .reset() shouldn't be "cold"
struct module_interface::reset() is called from the trigger IPC context, therefore it shouldn't be "cold." Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
1 parent 9313f30 commit 97f7301

3 files changed

Lines changed: 4 additions & 7 deletions

File tree

src/audio/multiband_drc/multiband_drc.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -407,12 +407,10 @@ __cold static int multiband_drc_prepare(struct processing_module *mod,
407407
return ret;
408408
}
409409

410-
__cold static int multiband_drc_reset(struct processing_module *mod)
410+
static int multiband_drc_reset(struct processing_module *mod)
411411
{
412412
struct multiband_drc_comp_data *cd = module_get_private_data(mod);
413413

414-
assert_can_be_cold();
415-
416414
comp_info(mod->dev, "multiband_drc_reset()");
417415

418416
multiband_drc_reset_state(&cd->state);

src/audio/src/src_common.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -697,12 +697,10 @@ __cold int src_get_config(struct processing_module *mod, uint32_t config_id,
697697
return -EINVAL;
698698
}
699699

700-
__cold int src_reset(struct processing_module *mod)
700+
int src_reset(struct processing_module *mod)
701701
{
702702
struct comp_data *cd = module_get_private_data(mod);
703703

704-
assert_can_be_cold();
705-
706704
comp_info(mod->dev, "src_reset()");
707705

708706
cd->src_func = src_fallback;

src/include/module/module/interface.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -214,7 +214,8 @@ struct module_interface {
214214
/**
215215
* (optional) Module specific reset procedure, called as part of module_adapter component
216216
* reset in .reset(). This should reset all parameters to their initial stage
217-
* and free all memory allocated during prepare(). Usually can be __cold
217+
* and free all memory allocated during prepare(). Usually shouldn't be __cold since it's
218+
* called from pipeline_reset() from ipc4_pipeline_trigger()
218219
*/
219220
int (*reset)(struct processing_module *mod);
220221

0 commit comments

Comments
 (0)