From 6e30e065ef2f198c03a5b79b1186e90ffd60bae3 Mon Sep 17 00:00:00 2001 From: Tony Narlock Date: Wed, 1 Apr 2026 18:56:59 -0500 Subject: [PATCH 1/2] fix(tests): fix flaky test_capture_pane_flags[join_wrapped_numbers] why: The command_complete() check matched the marker string inside the shell command echo line ($ printf ... echo "__DONE_...") before the command actually executed. On slower systems or CI, this race condition caused the test to capture the pane before seq produced output. what: - Change marker detection to skip lines starting with $ (shell prompt echo) - Marker now only matches when it appears as actual command output Fixes #654 --- tests/test_pane_capture_pane.py | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/tests/test_pane_capture_pane.py b/tests/test_pane_capture_pane.py index 5858cbd45..468025a78 100644 --- a/tests/test_pane_capture_pane.py +++ b/tests/test_pane_capture_pane.py @@ -356,10 +356,12 @@ def prompt_ready() -> bool: full_command = f'{command}; echo "{marker}"' pane.send_keys(full_command, literal=False, suppress_history=False) - # Wait for marker to appear + # Wait for marker to appear as command output (not in the command echo line) def command_complete() -> bool: - output = "\n".join(pane.capture_pane()) - return marker in output + lines = pane.capture_pane() + return any( + marker in line and not line.lstrip().startswith("$") for line in lines + ) retry_until(command_complete, 5, raises=True) From 33e94ab29ebf0ed9bca54d84d74145a1448d7280 Mon Sep 17 00:00:00 2001 From: Tony Narlock Date: Wed, 1 Apr 2026 19:03:46 -0500 Subject: [PATCH 2/2] docs(CHANGES) flaky join_wrapped_numbers test fix --- CHANGES | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/CHANGES b/CHANGES index 4c9cbe8e9..a044b9c18 100644 --- a/CHANGES +++ b/CHANGES @@ -162,6 +162,11 @@ attribute reads after a move could appear stale until a manual {meth}`~libtmux.Window.refresh` call. The moved window now refreshes automatically. +#### Flaky `test_capture_pane_flags[join_wrapped_numbers]` (#655) + +Marker detection now skips the shell command echo line to avoid +false-positive completion. + ### Documentation - Bump gp-sphinx docs stack to v0.0.1a16 — docs site now renders