Skip to content

document finiteness assumptions in the API #102

Description

@tpapp

When writing this package I implicitly assumed that that whenever the log density is finite, the gradient (and now the Hessian, see #101) are also.

So calling eg logdensity_and_gradient in the context of an MCMC sampler

fx, Dfx = logdensity_and_gradient(f, x)
if isfinite(fx)
   # proceed using DfX
else
   # reject point
end

The motivation for the non-finite log density is to provide an escape hatch for x being outside the support, non-convergent solvers, etc.

Should we

  1. document that whenever the log density is finite, so are the gradient and the Hessian?

  2. or allow cases of finite log density, with potentially non-finite gradient and Hessian? (What would be the use case?)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions