Skip to content

Commit 0933225

Browse files
committed
chore(webapp): address review nitpicks
Align size-[1.125rem] with the 4.5 spacing token, use a range for the tailwindcss version, document the intentional ::-moz-selection duplicate, and share the glow gradient stop list via a custom property.
1 parent fbdc105 commit 0933225

4 files changed

Lines changed: 18 additions & 27 deletions

File tree

apps/webapp/app/components/runs/v3/TaskTriggerSource.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,13 +13,13 @@ export function TaskTriggerSourceIcon({
1313
}) {
1414
switch (source) {
1515
case "STANDARD": {
16-
return <TaskIconSmall className={cn("size-[1.125rem] min-w-4.5 text-tasks", className)} />;
16+
return <TaskIconSmall className={cn("size-4.5 min-w-4.5 text-tasks", className)} />;
1717
}
1818
case "SCHEDULED": {
19-
return <ClockIcon className={cn("size-[1.125rem] min-w-4.5 text-schedules", className)} />;
19+
return <ClockIcon className={cn("size-4.5 min-w-4.5 text-schedules", className)} />;
2020
}
2121
case "AGENT": {
22-
return <CubeSparkleIcon className={cn("size-[1.125rem] min-w-4.5 text-agents", className)} />;
22+
return <CubeSparkleIcon className={cn("size-4.5 min-w-4.5 text-agents", className)} />;
2323
}
2424
}
2525
}

apps/webapp/app/tailwind.css

Lines changed: 12 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -351,6 +351,13 @@
351351
scrollbar-gutter: stable;
352352
}
353353

354+
/* Shared stop list for the animated glow utilities below. The gradient itself
355+
is assembled per-element so the animated --gradient-angle resolves there. */
356+
:root {
357+
--glow-gradient-stops: rgb(99 102 241), rgb(245 158 11), rgb(236 72 153), rgb(245 158 11),
358+
rgb(99 102 241);
359+
}
360+
354361
@utility animated-gradient-glow {
355362
position: relative;
356363
overflow: visible;
@@ -360,14 +367,7 @@
360367
position: absolute;
361368
inset: -8px;
362369
z-index: -1;
363-
background: conic-gradient(
364-
from var(--gradient-angle),
365-
rgb(99 102 241),
366-
rgb(245 158 11),
367-
rgb(236 72 153),
368-
rgb(245 158 11),
369-
rgb(99 102 241)
370-
);
370+
background: conic-gradient(from var(--gradient-angle), var(--glow-gradient-stops));
371371
border-radius: inherit;
372372
animation: gradient-rotation 3s linear infinite;
373373
pointer-events: none;
@@ -385,14 +385,7 @@
385385
position: absolute;
386386
inset: -1px;
387387
z-index: -1;
388-
background: conic-gradient(
389-
from var(--gradient-angle),
390-
rgb(99 102 241),
391-
rgb(245 158 11),
392-
rgb(236 72 153),
393-
rgb(245 158 11),
394-
rgb(99 102 241)
395-
);
388+
background: conic-gradient(from var(--gradient-angle), var(--glow-gradient-stops));
396389
border-radius: inherit;
397390
animation: gradient-rotation 3s linear infinite;
398391
pointer-events: none;
@@ -435,6 +428,9 @@
435428
::selection {
436429
@apply bg-text-bright/30 text-text-bright;
437430
}
431+
/* Kept separate from ::selection on purpose: grouping them makes older
432+
Firefox drop the whole rule. */
433+
/* stylelint-disable-next-line selector-no-vendor-prefix */
438434
::-moz-selection {
439435
@apply bg-text-bright/30 text-text-bright;
440436
}

apps/webapp/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -288,7 +288,7 @@
288288
"style-loader": "^3.3.4",
289289
"supertest": "^7.0.0",
290290
"tailwind-scrollbar": "^4.0.2",
291-
"tailwindcss": "4.3.1",
291+
"tailwindcss": "^4.3.1",
292292
"tsconfig-paths": "^3.14.1",
293293
"tsx": "^4.20.6",
294294
"vite-tsconfig-paths": "^4.0.5"

pnpm-lock.yaml

Lines changed: 2 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)