Skip to content

Commit 5d964b2

Browse files
ericallamclaude
andcommitted
feat(webapp): use canonical datasource labels for db_client metric attribute
Label each pool with its full datasource role (control-plane-writer, control-plane-replica, run-ops-writer, run-ops-replica, legacy-run-ops-writer, legacy-run-ops-replica) instead of the generic writer/reader, matching the db.datasource span attribute so metrics and traces correlate. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KHjfL7qXHia5DTnxi1RePS
1 parent c71c46b commit 5d964b2

1 file changed

Lines changed: 6 additions & 6 deletions

File tree

‎apps/webapp/app/db.server.ts‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -248,16 +248,16 @@ export function selectRunOpsTopology(
248248
if (config.legacySharesControlPlane) {
249249
legacyRunOps = controlPlane;
250250
} else {
251-
const legacyWriter = builders.buildLegacyWriter(config.legacyUrl, "run-ops-legacy-writer");
251+
const legacyWriter = builders.buildLegacyWriter(config.legacyUrl, "legacy-run-ops-writer");
252252
const legacyReplica: PrismaReplicaClient = config.legacyReplicaUrl
253-
? builders.buildLegacyReplica(config.legacyReplicaUrl, "run-ops-legacy-reader")
253+
? builders.buildLegacyReplica(config.legacyReplicaUrl, "legacy-run-ops-replica")
254254
: legacyWriter;
255255
legacyRunOps = { writer: legacyWriter, replica: legacyReplica };
256256
}
257257

258-
const newWriter = builders.buildNewWriter(config.newUrl, "run-ops-new-writer");
258+
const newWriter = builders.buildNewWriter(config.newUrl, "run-ops-writer");
259259
const newReplica: RunOpsPrismaClient = config.newReplicaUrl
260-
? builders.buildNewReplica(config.newReplicaUrl, "run-ops-new-reader")
260+
? builders.buildNewReplica(config.newReplicaUrl, "run-ops-replica")
261261
: newWriter;
262262

263263
return {
@@ -431,7 +431,7 @@ function getClient() {
431431

432432
return buildWriterClient({
433433
url,
434-
clientType: "writer",
434+
clientType: "control-plane-writer",
435435
poolTimeout: env.DATABASE_WRITER_POOL_TIMEOUT,
436436
connectTimeout: env.DATABASE_WRITER_CONNECTION_TIMEOUT,
437437
useDriverAdapter: env.CONTROL_PLANE_DATABASE_WRITER_DRIVER_ADAPTER === "1",
@@ -664,7 +664,7 @@ function getReplicaClient() {
664664

665665
return buildReplicaClient({
666666
url,
667-
clientType: "reader",
667+
clientType: "control-plane-replica",
668668
poolTimeout: env.DATABASE_READ_REPLICA_POOL_TIMEOUT,
669669
connectTimeout: env.DATABASE_READ_REPLICA_CONNECTION_TIMEOUT,
670670
useDriverAdapter: env.CONTROL_PLANE_DATABASE_REPLICA_DRIVER_ADAPTER === "1",

0 commit comments

Comments
 (0)