Skip to content

Commit 94eaef6

Browse files
d-csclaude
andcommitted
test(run-ops): reconcile ApiBatchResultsPresenter split test with read-through presenter design
The pr04-era ApiBatchResultsPresenter.split.test.ts asserted a bare `new ApiBatchResultsPresenter()` routes the batch-row lookup through the runStore singleton (via vi.mock("~/v3/runStore.server")) so a NEW-resident ksuid batch resolves. pr08's call() supersedes that contract: a bare presenter has readThrough === undefined, so splitEnabled is false and it takes #callPassthrough, which reads this._replica.batchTaskRun directly (not through runStore). The test therefore fails against pr08 and encodes a design that no longer exists. Both cases it covered are already covered by pr08's own apiBatchResultsPresenter.readthrough.test.ts against the current #callSplit API: (a) a NEW-resident batch resolving under split (batch row + items on the NEW DB, resolved via newClient) and (b) a genuinely-missing batch returning undefined (split on). Remove the redundant, superseded test. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent b320ba5 commit 94eaef6

1 file changed

Lines changed: 0 additions & 97 deletions

File tree

apps/webapp/test/presenters/ApiBatchResultsPresenter.split.test.ts

Lines changed: 0 additions & 97 deletions
This file was deleted.

0 commit comments

Comments
 (0)