chore: activate no-unused-vars and import linters (#4096)

Once this is merged, oxlint is at a pretty sensible baseline.

**Enable `no-unused-vars`, `typescript/consistent-type-imports`, and
`import/no-duplicates` lint rules**

Turns on three previously-disabled oxlint rules across the monorepo and
fixes all violations:

- **`no-unused-vars`** – enabled as an error with standard ignore
patterns: unused function arguments are ignored by default (`args:
"none"`), variables/caught errors/destructured array elements prefixed
with `_` are allowed, and rest siblings are permitted.
- **`typescript/consistent-type-imports`** – enforced as an error; all
type-only imports now use the `import type` syntax.
- **`import/no-duplicates`** – enforced as an error; duplicate import
statements from the same module have been merged.

The remaining commits clean up the violations found across the codebase:
removing unused variables/imports/type aliases, adding `_` prefixes to
intentionally unused bindings, fixing duplicate imports, and converting
value imports to `import type` where appropriate.

Author: carderne

.oxlintrc.json

@@ -11,13 +11,24 @@
     "internal-packages/tsql/src/grammar/"
   ],
   "rules": {
-    "no-unused-vars": "off",
+    "no-unused-vars": [
+      "error",
+      {
+        "args": "none",
+        "argsIgnorePattern": "^_",
+        "varsIgnorePattern": "^_",
+        "caughtErrors": "all",
+        "caughtErrorsIgnorePattern": "^_",
+        "destructuredArrayIgnorePattern": "^_",
+        "ignoreRestSiblings": true
+      }
+    ],
     "no-empty-pattern": "off",
     "no-control-regex": "off",
     "typescript/no-non-null-asserted-optional-chain": "off",
     "no-unused-expressions": ["warn", { "allowShortCircuit": true, "allowTernary": true }],
-    "typescript/consistent-type-imports": "off",
-    "import/no-duplicates": "off",
+    "typescript/consistent-type-imports": "error",
+    "import/no-duplicates": "error",
     "import/namespace": "off",
     "react-hooks/exhaustive-deps": "off",
     "react-hooks/rules-of-hooks": "off"

apps/coordinator/src/checkpointer.ts

@@ -334,7 +334,7 @@ export class Checkpointer {
 
       try {
         await setTimeout(delayMs, undefined, { signal });
-      } catch (error) {
+      } catch (_error) {
         this.#logger.log("Checkpoint canceled during initial delay", { runId });
         return { success: false, reason: "CANCELED" };
       }
@@ -364,7 +364,7 @@ export class Checkpointer {
 
           try {
             await setTimeout(delay.milliseconds, undefined, { signal });
-          } catch (error) {
+          } catch (_error) {
             this.#logger.log("Checkpoint canceled during retry delay", { runId });
             return { success: false, reason: "CANCELED" };
           }

apps/coordinator/src/exec.ts

@@ -208,7 +208,7 @@ export class Buildah {
     try {
       await x("buildah", ["login", "--get-login", registryHost], { throwOnError: true });
       return true;
-    } catch (error) {
+    } catch (_error) {
       return false;
     }
   }

apps/coordinator/src/index.ts

@@ -1,13 +1,13 @@
 import { createServer } from "node:http";
 import { Server } from "socket.io";
+import type { WaitReason } from "@trigger.dev/core/v3";
 import {
   CoordinatorToPlatformMessages,
   CoordinatorToProdWorkerMessages,
   omit,
   PlatformToCoordinatorMessages,
   ProdWorkerSocketData,
   ProdWorkerToCoordinatorMessages,
-  WaitReason,
 } from "@trigger.dev/core/v3";
 import { ZodNamespace } from "@trigger.dev/core/v3/zodNamespace";
 import { ZodSocketConnection } from "@trigger.dev/core/v3/zodSocket";

apps/coordinator/src/util.ts

@@ -25,7 +25,7 @@ export function safeJsonParse(json?: string): unknown {
 
   try {
     return JSON.parse(json);
-  } catch (e) {
+  } catch (_e) {
     return null;
   }
 }

apps/docker-provider/src/index.ts

@@ -1,16 +1,14 @@
-import { $, type ExecaChildProcess, execa } from "execa";
-import {
-  ProviderShell,
+import type { PostStartCauses, PreStopCauses } from "@trigger.dev/core/v3";
+import type {
   TaskOperations,
   TaskOperationsCreateOptions,
   TaskOperationsIndexOptions,
   TaskOperationsRestoreOptions,
 } from "@trigger.dev/core/v3/apps";
-import { SimpleLogger } from "@trigger.dev/core/v3/apps";
-import { isExecaChildProcess } from "@trigger.dev/core/v3/apps";
+import { ProviderShell, SimpleLogger, isExecaChildProcess } from "@trigger.dev/core/v3/apps";
 import { testDockerCheckpoint } from "@trigger.dev/core/v3/serverOnly";
+import { $, type ExecaChildProcess, execa } from "execa";
 import { setTimeout } from "node:timers/promises";
-import { PostStartCauses, PreStopCauses } from "@trigger.dev/core/v3";
 
 const MACHINE_NAME = process.env.MACHINE_NAME || "local";
 const COORDINATOR_PORT = process.env.COORDINATOR_PORT || 8020;

apps/kubernetes-provider/src/index.ts

@@ -1,19 +1,18 @@
 import * as k8s from "@kubernetes/client-node";
-import {
+import type {
   EnvironmentType,
   MachinePreset,
   PostStartCauses,
   PreStopCauses,
 } from "@trigger.dev/core/v3";
-import {
-  ProviderShell,
-  SimpleLogger,
+import type {
   TaskOperations,
   TaskOperationsCreateOptions,
   TaskOperationsIndexOptions,
   TaskOperationsPrePullDeploymentOptions,
   TaskOperationsRestoreOptions,
 } from "@trigger.dev/core/v3/apps";
+import { ProviderShell, SimpleLogger } from "@trigger.dev/core/v3/apps";
 import { PodCleaner } from "./podCleaner";
 import { TaskMonitor } from "./taskMonitor";
 import { UptimeHeartbeat } from "./uptimeHeartbeat";

apps/kubernetes-provider/src/taskMonitor.ts

@@ -1,9 +1,12 @@
 import * as k8s from "@kubernetes/client-node";
-import { SimpleLogger } from "@trigger.dev/core/v3/apps";
-import { EXIT_CODE_ALREADY_HANDLED, EXIT_CODE_CHILD_NONZERO } from "@trigger.dev/core/v3/apps";
-import { setTimeout } from "timers/promises";
-import PQueue from "p-queue";
 import { TaskRunErrorCodes, type Prettify, type TaskRunInternalError } from "@trigger.dev/core/v3";
+import {
+  EXIT_CODE_ALREADY_HANDLED,
+  EXIT_CODE_CHILD_NONZERO,
+  SimpleLogger,
+} from "@trigger.dev/core/v3/apps";
+import PQueue from "p-queue";
+import { setTimeout } from "timers/promises";
 
 type FailureDetails = Prettify<{
   exitCode: number;

apps/supervisor/src/clients/kubernetes.ts

@@ -1,10 +1,8 @@
-import * as https from "node:https";
 import * as k8s from "@kubernetes/client-node";
-import { Informer } from "@kubernetes/client-node";
-import { ListPromise } from "@kubernetes/client-node";
-import { KubernetesObject } from "@kubernetes/client-node";
+import type { Informer, KubernetesObject, ListPromise } from "@kubernetes/client-node";
 import { assertExhaustive } from "@trigger.dev/core/utils";
 import { SimpleStructuredLogger } from "@trigger.dev/core/v3/utils/structuredLogger";
+import * as https from "node:https";
 
 export const RUNTIME_ENV = process.env.KUBERNETES_PORT ? "kubernetes" : "local";
 

apps/supervisor/src/services/failedPodHandler.test.ts

@@ -14,7 +14,7 @@ describe.skipIf(!process.env.K8S_INTEGRATION_TESTS)("FailedPodHandler Integratio
     // Create the test namespace if it doesn't exist
     try {
       await k8s.core.readNamespace({ name: namespace });
-    } catch (error) {
+    } catch (_error) {
       await k8s.core.createNamespace({
         body: {
           metadata: {