Skip to content

Commit dcb7287

Browse files
committed
feat(webapp): use a bolt icon for smart columns and reveal row actions on hover
Marks smart columns with a bolt icon, and the display-options rows now show edit/remove/drag only on hover so a resting list is just a checkbox and a name.
1 parent 5b4371f commit dcb7287

3 files changed

Lines changed: 10 additions & 10 deletions

File tree

apps/webapp/app/components/runs/v3/AddSmartColumnDialog.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { VariableIcon } from "@heroicons/react/20/solid";
1+
import { BoltIcon } from "@heroicons/react/20/solid";
22
import { useEffect, useMemo, useState } from "react";
33
import { useTypedFetcher } from "remix-typedjson";
44
import { Button } from "~/components/primitives/Buttons";
@@ -253,7 +253,7 @@ function SmartColumnResolvedPreview({
253253
return (
254254
<div className="rounded border border-grid-dimmed">
255255
<div className="flex items-center gap-1 border-b border-grid-dimmed px-2 py-1">
256-
<VariableIcon className="size-3.5 flex-none text-text-dimmed" />
256+
<BoltIcon className="size-3.5 flex-none text-text-dimmed" />
257257
<span className="truncate text-xs text-text-bright">{label || "Column"}</span>
258258
</div>
259259
<div className="px-2 py-1.5 text-right text-sm tabular-nums text-text-bright">{value}</div>

apps/webapp/app/components/runs/v3/RunsDisplayOptions.tsx

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import {
22
ArrowUturnLeftIcon,
33
PencilSquareIcon,
44
PlusIcon,
5-
VariableIcon,
5+
BoltIcon,
66
ViewColumnsIcon,
77
XMarkIcon,
88
} from "@heroicons/react/20/solid";
@@ -224,7 +224,7 @@ function ColumnRow({
224224
return (
225225
<div
226226
className={cn(
227-
"relative flex h-8 items-center gap-2 px-3 transition-colors hover:bg-charcoal-750",
227+
"group relative flex h-8 items-center gap-2 px-3 transition-colors hover:bg-charcoal-750",
228228
dragging && "opacity-40"
229229
)}
230230
draggable
@@ -236,7 +236,7 @@ function ColumnRow({
236236
>
237237
{isOver && <div className="absolute inset-x-0 top-0 h-0.5 bg-blue-500" />}
238238
{locked ? <Checkbox checked disabled /> : <Checkbox checked={checked} onChange={onToggle} />}
239-
{isSmart && <VariableIcon className="size-4 flex-none text-text-dimmed" />}
239+
{isSmart && <BoltIcon className="size-4 flex-none text-text-dimmed" />}
240240
<span
241241
className={cn("flex-1 truncate text-sm", checked ? "text-text-bright" : "text-text-dimmed")}
242242
>
@@ -247,7 +247,7 @@ function ColumnRow({
247247
type="button"
248248
onClick={onEdit}
249249
aria-label={`Edit ${col.def.label}`}
250-
className="flex size-5 items-center justify-center rounded text-text-dimmed transition-colors hover:text-text-bright focus-custom"
250+
className="flex size-5 items-center justify-center rounded text-text-dimmed opacity-0 transition hover:text-text-bright focus-custom group-hover:opacity-100"
251251
>
252252
<PencilSquareIcon className="size-3.5" />
253253
</button>
@@ -257,12 +257,12 @@ function ColumnRow({
257257
type="button"
258258
onClick={onRemove}
259259
aria-label={`Remove ${col.def.label}`}
260-
className="flex size-5 items-center justify-center rounded text-text-dimmed transition-colors hover:text-error focus-custom"
260+
className="flex size-5 items-center justify-center rounded text-text-dimmed opacity-0 transition hover:text-error focus-custom group-hover:opacity-100"
261261
>
262262
<XMarkIcon className="size-3.5" />
263263
</button>
264264
)}
265-
<GripVerticalIcon className="size-4 cursor-grab text-text-dimmed active:cursor-grabbing" />
265+
<GripVerticalIcon className="size-4 flex-none cursor-grab text-text-dimmed opacity-0 transition group-hover:opacity-100 active:cursor-grabbing" />
266266
</div>
267267
);
268268
}

apps/webapp/app/components/runs/v3/TaskRunsTable.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import {
22
ArrowPathIcon,
33
ArrowRightIcon,
44
ClockIcon,
5-
VariableIcon,
5+
BoltIcon,
66
CpuChipIcon,
77
NoSymbolIcon,
88
RectangleStackIcon,
@@ -482,7 +482,7 @@ function SmartColumnHeader({ def }: { def: SmartColumnDef }) {
482482
return (
483483
<TableHeaderCell>
484484
<span className="flex items-center gap-1">
485-
<VariableIcon className="size-3.5 flex-none text-text-dimmed" />
485+
<BoltIcon className="size-3.5 flex-none text-text-dimmed" />
486486
<span className="truncate">{def.label}</span>
487487
</span>
488488
</TableHeaderCell>

0 commit comments

Comments
 (0)