chore: enable more linters by carderne · Pull Request #4080 · triggerdotdev/trigger.dev

carderne · 2026-06-30T10:21:49Z

Summary

Re-enables ~15 oxlint rules that were blanket-disabled before.

Rules re-enabled and how violations were fixed

`no-useless-catch` (4 violations)

One-line disabled.

`no-unreachable` (3 violations)

mintlifyClient.ts: removed a throw after a while(true) loop that already throws/returns internally.
taskExecutor.test.ts: removed dead await next() + push after a deliberate throw in a test middleware.

`require-yield` (2 violations)

Ignored at site.

`no-async-promise-executor` (2 violations)

backoff.ts: replaced new Promise(async (resolve, reject) => { ... callback().then(resolve) }) with the idiomatic callback(...).then(resolve, reject).
zodIpc.ts: removed async from the executor and changed await this.#sendPacket(...) to this.#sendPacket(...).catch(reject).

`no-unsafe-finally` (1 violation)

checkpointer.ts deliberately uses return inside finally to override the try-block result when the signal is aborted (comment: "Overrides any prior return value"). Added // eslint-disable-next-line no-unsafe-finally with an explanation rather than refactoring the cancellation logic.

`typescript/no-unnecessary-parameter-property-assignment` (1 violation)

apiClient.ts constructor had both public readonly branch?: string (parameter property) and this.branch = branch (manual assignment). Removed the redundant assignment.

`react/no-children-prop` (1 violation)

Select.tsx: converted <SelectGroupedRenderer children={children} /> to <SelectGroupedRenderer>{children}</SelectGroupedRenderer>.

`react/jsx-key` (3 violations)

Added key props to mapped JSX in debugRun.tsx and the models comparison route (key={m} on the Provider span and the feature CheckIcon).

`no-unused-private-class-members` (5 violations)

Deleted genuinely dead private methods:

marqs/index.server.ts — #saveMessage (superseded by #saveMessageIfExists)
fair-queue/index.ts — #incrementCooloff (partially-implemented feature, never wired up)
taskMonitor.ts — #launchTests (76-line dev scaffolding, never called)
podCleaner.ts — #deleteUnrecoverableRuns + #launchTests (62 lines of test pod creation, never called)

`typescript/no-this-alias` (13 violations)

Just did disable at the site.

`no-useless-escape` (44 violations)

Nearly all were auto-fixed by oxlint --fix. Three manual fixes:

gitBranch.ts: /[ ~\^:?\*[\\]/ → /[ ~^:?*[\\]/ (inside a character class ^ and * don't need escaping).
TSQLParser.ts (generated file): \'\' → '' inside a double-quoted string.

`no-unused-expressions` (27 violations)

Enabled with ["warn", { "allowShortCircuit": true, "allowTernary": true }] — this covers the common warn && log(...) and condition ? a() : b() patterns used throughout the CLI and webapp. The 11 remaining violations were in triggerClient.types.test.ts: expressions like client.tasks.triggerAndWait; used purely for TypeScript type-checking (paired with // @ts-expect-error). Fixed by adding void prefix: void client.tasks.triggerAndWait;.

changeset-bot · 2026-06-30T10:21:55Z

⚠️ No Changeset found

Latest commit: 75cff06

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2026-06-30T10:22:51Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: dc31f45d-02a4-4b27-aa72-6bb62762eee6

📥 Commits

Reviewing files that changed from the base of the PR and between 9c5289e and 75cff06.

📒 Files selected for processing (5)

.oxlintrc.json
apps/webapp/app/v3/GCRARateLimiter.server.ts
packages/cli-v3/src/dev/devSupervisor.ts
packages/cli-v3/src/utilities/gitMeta.ts
packages/core/src/v3/realtimeStreams/streamsWriterV1.ts

✅ Files skipped from review due to trivial changes (3)

apps/webapp/app/v3/GCRARateLimiter.server.ts
packages/cli-v3/src/utilities/gitMeta.ts
packages/core/src/v3/realtimeStreams/streamsWriterV1.ts

🚧 Files skipped from review as they are similar to previous changes (1)

.oxlintrc.json

📜 Recent review details

⏰ Context from checks skipped due to timeout. (1)

GitHub Check: internal / 🧪 Unit Tests: Internal (3, 12)

🧰 Additional context used

📓 Path-based instructions (7)

**/*.{ts,tsx}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

**/*.{ts,tsx}: Use types over interfaces for TypeScript
Avoid using enums; prefer string unions or const objects instead

Files:

packages/cli-v3/src/dev/devSupervisor.ts

**/*.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Use function declarations instead of default exports

Files:

packages/cli-v3/src/dev/devSupervisor.ts

**/*.ts

📄 CodeRabbit inference engine (.cursor/rules/otel-metrics.mdc)

**/*.ts: When creating or editing OTEL metrics (counters, histograms, gauges), ensure metric attributes have low cardinality by using only enums, booleans, bounded error codes, or bounded shard IDs
Do not use high-cardinality attributes in OTEL metrics such as UUIDs/IDs (envId, userId, runId, projectId, organizationId), unbounded integers (itemCount, batchSize, retryCount), timestamps (createdAt, startTime), or free-form strings (errorMessage, taskName, queueName)
When exporting OTEL metrics via OTLP to Prometheus, be aware that the exporter automatically adds unit suffixes to metric names (e.g., 'my_duration_ms' becomes 'my_duration_ms_milliseconds', 'my_counter' becomes 'my_counter_total'). Account for these transformations when writing Grafana dashboards or Prometheus queries

Files:

packages/cli-v3/src/dev/devSupervisor.ts

packages/cli-v3/src/dev/**/*

📄 CodeRabbit inference engine (packages/cli-v3/CLAUDE.md)

Dev mode code should be located in src/dev/ and runs tasks locally in the user's Node.js process without containers

Files:

packages/cli-v3/src/dev/devSupervisor.ts

**/*.{ts,tsx,js,jsx,mts,cts,mjs,cjs}

📄 CodeRabbit inference engine (CLAUDE.md)

**/*.{ts,tsx,js,jsx,mts,cts,mjs,cjs}: Use pnpm run typecheck for changes in apps (apps/*) and internal packages (internal-packages/*), and never use build to verify those changes.
Use Vitest for tests, and never mock anything; use testcontainers instead.
Prefer static imports over dynamic import(), and only use dynamic imports for unresolved circular dependencies, genuine code-splitting needs, or conditional runtime loading.

Files:

packages/cli-v3/src/dev/devSupervisor.ts

packages/**/*.{ts,tsx,js,jsx,mts,cts,mjs,cjs}

📄 CodeRabbit inference engine (CLAUDE.md)

Use pnpm run build to verify changes in public packages (packages/*).

Files:

packages/cli-v3/src/dev/devSupervisor.ts

**/*.{ts,tsx,js,jsx,mts,cts,mjs,cjs,md,mdx}

📄 CodeRabbit inference engine (CLAUDE.md)

Always import from @trigger.dev/sdk when writing Trigger.dev tasks; never use @trigger.dev/sdk/v3 or deprecated client.defineJob.

Files:

packages/cli-v3/src/dev/devSupervisor.ts

🧠 Learnings (9)

📚 Learning: 2026-03-22T13:26:12.060Z

Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3244
File: apps/webapp/app/components/code/TextEditor.tsx:81-86
Timestamp: 2026-03-22T13:26:12.060Z
Learning: In the triggerdotdev/trigger.dev codebase, do not flag `navigator.clipboard.writeText(...)` calls for `missing-await`/`unhandled-promise` issues. These clipboard writes are intentionally invoked without `await` and without `catch` handlers across the project; keep that behavior consistent when reviewing TypeScript/TSX files (e.g., usages like in `apps/webapp/app/components/code/TextEditor.tsx`).

Applied to files:

packages/cli-v3/src/dev/devSupervisor.ts

📚 Learning: 2026-03-22T19:24:14.403Z

Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3187
File: apps/webapp/app/v3/services/alerts/deliverErrorGroupAlert.server.ts:200-204
Timestamp: 2026-03-22T19:24:14.403Z
Learning: In the triggerdotdev/trigger.dev codebase, webhook URLs are not expected to contain embedded credentials/secrets (e.g., fields like `ProjectAlertWebhookProperties` should only hold credential-free webhook endpoints). During code review, if you see logging or inclusion of raw webhook URLs in error messages, do not automatically treat it as a credential-leak/secrets-in-logs issue by default—first verify the URL does not contain embedded credentials (for example, no username/password in the URL, no obvious secret/token query params or fragments). If the URL is credential-free per this project’s conventions, allow the logging.

Applied to files:

packages/cli-v3/src/dev/devSupervisor.ts

📚 Learning: 2026-05-18T08:21:27.694Z

Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3632
File: apps/webapp/sentry.server.ts:4-21
Timestamp: 2026-05-18T08:21:27.694Z
Learning: When handling Prisma error P1001 ("Can't reach database server") in TypeScript, don’t assume a single error shape. Prisma can surface P1001 via two different error classes/fields: `PrismaClientKnownRequestError` exposes it as `err.code === "P1001"` (common during mid-query connection drops), while `PrismaClientInitializationError` exposes it as `err.errorCode === "P1001"` (common on client startup failure). Therefore, predicates should use `err.code === "P1001" || err.errorCode === "P1001"`. Do not flag `err.code === "P1001"` as “unreachable/never matches,” as it is expected in production.

Applied to files:

packages/cli-v3/src/dev/devSupervisor.ts

📚 Learning: 2026-05-18T08:21:27.694Z

Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3632
File: apps/webapp/sentry.server.ts:4-21
Timestamp: 2026-05-18T08:21:27.694Z
Learning: When handling Prisma errors for P1001 ("Can't reach database server"), do not assume it only appears under a single property name. Prisma may surface P1001 via either `PrismaClientKnownRequestError` (`err.code === "P1001"`, e.g., mid-query connection drops) or `PrismaClientInitializationError` (`err.errorCode === "P1001"`, e.g., client startup connection failure). To reliably detect the condition, check `err.code === "P1001" || err.errorCode === "P1001"`, and avoid review rules that would incorrectly flag `err.code === "P1001"` as unreachable/never-matching.

Applied to files:

packages/cli-v3/src/dev/devSupervisor.ts

📚 Learning: 2026-06-13T19:53:13.759Z

Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3937
File: packages/trigger-sdk/skills/realtime-and-frontend/SKILL.md:258-260
Timestamp: 2026-06-13T19:53:13.759Z
Learning: When reviewing code that uses `trigger.dev/react-hooks`’s `useRealtimeRun`, preserve the call signature where the first argument is the full realtime handle object (not `handle.id`). This is intentional to maintain type-safety and is consistent with the official docs; do not suggest changing the first argument from the handle object to `handle.id`.

Applied to files:

packages/cli-v3/src/dev/devSupervisor.ts

📚 Learning: 2026-06-17T17:13:49.929Z

Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3948
File: apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.bulk-actions.$bulkActionParam/route.tsx:48-62
Timestamp: 2026-06-17T17:13:49.929Z
Learning: In triggerdotdev/trigger.dev, within `dashboardLoader`/`dashboardAction` (or similar context resolver code) whenever you resolve an organization ID from an organization slug for RBAC/enterprise authorization scope, always read from the primary Prisma client (`prisma`), not `$replica`. Using `$replica` can hit replica-lag and cause the RBAC lookup/authorization to run without the correct org scope (bypassing intended role enforcement). Implement the slug→org lookup with `prisma.organization.findFirst(...)` (or equivalent primary-client query) and add an inline comment documenting why the primary client is required (replica lag could lead to unscoped RBAC checks).

Applied to files:

packages/cli-v3/src/dev/devSupervisor.ts

📚 Learning: 2026-06-23T13:04:21.413Z

Learnt from: carderne
Repo: triggerdotdev/trigger.dev PR: 4023
File: apps/webapp/app/services/upsertBranch.server.ts:14-18
Timestamp: 2026-06-23T13:04:21.413Z
Learning: In TypeScript, it’s valid to `import { type X }` and then use `typeof X` in a type-only position, e.g. `type Alias = z.infer<typeof X>`. The `type` modifier suppresses the runtime import, but the type checker still has the full exported type so `z.infer<typeof X>` can resolve correctly. In code reviews, don’t flag this as a TypeScript compile error as long as `typeof X` is used in a type context (e.g., with `z.infer`, `type` aliases, generics), not as a runtime value.

Applied to files:

packages/cli-v3/src/dev/devSupervisor.ts

📚 Learning: 2026-06-04T18:16:35.386Z

Learnt from: nicktrn
Repo: triggerdotdev/trigger.dev PR: 3836
File: apps/supervisor/src/backpressure/backpressureMonitor.ts:3-5
Timestamp: 2026-06-04T18:16:35.386Z
Learning: When reviewing TypeScript in this repo, apply the rule “prefer type aliases over interfaces” only to data/object shapes and union/intersection type modeling. If an interface is being used as a behavioral contract for collaborators to implement (e.g., method-shape interfaces that define required behavior, such as `BackpressureLogger` / `BackpressureSignalSource` in `apps/supervisor/src/backpressure/backpressureMonitor.ts`), keep it as an `interface` and do not flag it as a type-alias-vs-interface violation.

Applied to files:

packages/cli-v3/src/dev/devSupervisor.ts

📚 Learning: 2026-06-09T17:58:04.699Z

Learnt from: 0ski
Repo: triggerdotdev/trigger.dev PR: 3879
File: apps/webapp/app/models/vercelIntegration.server.ts:619-630
Timestamp: 2026-06-09T17:58:04.699Z
Learning: In this codebase, outbound raw `fetch` calls should typically rely on Node/undici’s default request timeout (about ~300s) rather than adding a per-call `AbortController` + `setTimeout` wrapper inside individual functions (e.g. in files like `apps/webapp/app/models/vercelIntegration.server.ts`). During code review, do not flag the absence of a per-call timeout on a single `fetch` as an issue; if per-call timeouts are needed, they should be implemented via a codebase-wide convention (e.g., a shared fetch wrapper or documented pattern) rather than ad-hoc per-function changes.

Applied to files:

packages/cli-v3/src/dev/devSupervisor.ts

🪛 ast-grep (0.44.0)

packages/cli-v3/src/dev/devSupervisor.ts

[warning] Importing child_process exposes a command-execution surface; ensure any command/argument built from input is validated, and prefer execFile/spawn with an argument array over exec.
Context: import { spawn, type ChildProcess } from "node:child_process";
Note: [CWE-78] Improper Neutralization of Special Elements used in an OS Command ('OS Command Injection').

(detect-child-process-typescript)

🔇 Additional comments (1)

packages/cli-v3/src/dev/devSupervisor.ts (1)

615-618: LGTM!

Walkthrough

The PR narrows the .oxlintrc.json rule set and adds targeted lint suppressions in runtime and test code. It also updates several regex character classes, changes Promise handling in backoff and IPC code, removes helper paths for launching test pods and saving messages, adjusts Socket.IO upgrade behavior, adds React key props in mapped renders, and updates tests for SQL quoting, schedule recovery values, type-level assertions, and wire-shape assertions.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description covers the changes, but it omits required template sections like Closes `#issue`, checklist, testing, changelog, and screenshots.	Add the template sections and fill in the issue reference, checklist items, testing steps, changelog, and screenshots placeholders.
Docstring Coverage	⚠️ Warning	Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title is concise and accurately summarizes the main change: re-enabling linters.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch chore/linting

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

pkg-pr-new · 2026-06-30T10:31:31Z

Open in StackBlitz

@trigger.dev/build

npm i https://pkg.pr.new/@trigger.dev/build@75cff06

trigger.dev

npm i https://pkg.pr.new/trigger.dev@75cff06

@trigger.dev/core

npm i https://pkg.pr.new/@trigger.dev/core@75cff06

@trigger.dev/python

npm i https://pkg.pr.new/@trigger.dev/python@75cff06

@trigger.dev/react-hooks

npm i https://pkg.pr.new/@trigger.dev/react-hooks@75cff06

@trigger.dev/redis-worker

npm i https://pkg.pr.new/@trigger.dev/redis-worker@75cff06

@trigger.dev/rsc

npm i https://pkg.pr.new/@trigger.dev/rsc@75cff06

@trigger.dev/schema-to-json

npm i https://pkg.pr.new/@trigger.dev/schema-to-json@75cff06

@trigger.dev/sdk

npm i https://pkg.pr.new/@trigger.dev/sdk@75cff06

commit: 75cff06

…able

…tead

…fixture ({}) syntax

…isable block

…ges; fix no-unsafe-optional-chaining with !

devin-ai-integration

Devin Review found 1 potential issue.

chore: enable more linters

7a42a9b

carderne force-pushed the chore/linting branch from f0216c1 to 7a42a9b Compare June 30, 2026 10:25

format

6858f43

carderne added 2 commits June 30, 2026 11:32

chore: restore GCRARateLimiter catch with policy comment + eslint-dis…

57940f8

…able

chore: restore return reject() pattern in zodIpc

63046b1

This comment was marked as resolved.

Sign in to view

carderne added 11 commits June 30, 2026 11:51

ignore tsql

4972dfe

chore: revert try-catch and self=this changes, use eslint-disable ins…

39fffa3

…tead

chore: disable no-empty-pattern in test files via overrides, restore …

376d8eb

…fixture ({}) syntax

chore: disable no-empty-pattern globally, revert fixture changes

0122292

chore: restore unreachable throw in mintlifyClient, add eslint-disable

9d8658b

chore: disable no-control-regex globally, revert regex changes

2b2a512

nit

c157ed4

chore: restore unreachable code in taskExecutor.test.ts, add eslint-d…

9c5289e

…isable block

chore: disable no-non-null-asserted-optional-chain, revert those chan…

b7be7a8

…ges; fix no-unsafe-optional-chaining with !

chore: fix no-unsafe-optional-chaining in wire-shape.test.ts

734e604

fmt

75cff06

carderne marked this pull request as ready for review June 30, 2026 11:33

devin-ai-integration Bot reviewed Jun 30, 2026

View reviewed changes

Comment thread packages/redis-worker/src/fair-queue/index.ts

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

chore: enable more linters#4080

chore: enable more linters#4080
carderne wants to merge 15 commits into
mainfrom
chore/linting

carderne commented Jun 30, 2026 •

edited

Loading

Uh oh!

changeset-bot Bot commented Jun 30, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Jun 30, 2026 •

edited

Loading

❌ Failed checks (2 warnings)

Uh oh!

pkg-pr-new Bot commented Jun 30, 2026 •

edited

Loading

Uh oh!

This comment was marked as resolved.

Uh oh!

devin-ai-integration Bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Uh oh!

Conversation

carderne commented Jun 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Rules re-enabled and how violations were fixed

no-useless-catch (4 violations)

no-unreachable (3 violations)

require-yield (2 violations)

no-async-promise-executor (2 violations)

no-unsafe-finally (1 violation)

typescript/no-unnecessary-parameter-property-assignment (1 violation)

react/no-children-prop (1 violation)

react/jsx-key (3 violations)

no-unused-private-class-members (5 violations)

typescript/no-this-alias (13 violations)

no-useless-escape (44 violations)

no-unused-expressions (27 violations)

Uh oh!

changeset-bot Bot commented Jun 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

coderabbitai Bot commented Jun 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

❌ Failed checks (2 warnings)

Uh oh!

pkg-pr-new Bot commented Jun 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as resolved.

Uh oh!

devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

carderne commented Jun 30, 2026 •

edited

Loading

`no-useless-catch` (4 violations)

`no-unreachable` (3 violations)

`require-yield` (2 violations)

`no-async-promise-executor` (2 violations)

`no-unsafe-finally` (1 violation)

`typescript/no-unnecessary-parameter-property-assignment` (1 violation)

`react/no-children-prop` (1 violation)

`react/jsx-key` (3 violations)

`no-unused-private-class-members` (5 violations)

`typescript/no-this-alias` (13 violations)

`no-useless-escape` (44 violations)

`no-unused-expressions` (27 violations)

changeset-bot Bot commented Jun 30, 2026 •

edited

Loading

coderabbitai Bot commented Jun 30, 2026 •

edited

Loading

pkg-pr-new Bot commented Jun 30, 2026 •

edited

Loading