Skip to content

Commit a08892e

Browse files
joseph-isaacsclaude
andcommitted
test(array): gate NEON take bounds test to aarch64
`take_small_byte_table_rejects_out_of_bounds_index` asserts the NEON small-table bounds-check message, but the table path only exists on little-endian AArch64. On other targets `take_values` falls through to the AVX2 or scalar path, whose panic messages differ, so the test failed on the linux-musl runner (no AVX2: the scalar path panics with the plain slice message). Gate the test on the same cfg as the module. `take_small_byte_table` stays unconditional so every target keeps checking the results. Signed-off-by: "Joe Isaacs" <joe.isaacs@live.co.uk> Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013YND3Jq47YtL15ob3GEsVY
1 parent e97db31 commit a08892e

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

  • vortex-array/src/arrays/fixed_width/take

vortex-array/src/arrays/fixed_width/take/tests.rs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,9 @@ fn take_small_byte_table() {
5252
);
5353
}
5454

55+
// The bounds-check message is specific to the NEON table path; other targets reach a different
56+
// fallback with its own message.
57+
#[cfg(all(target_arch = "aarch64", target_endian = "little"))]
5558
#[test]
5659
#[should_panic(expected = "take index")]
5760
fn take_small_byte_table_rejects_out_of_bounds_index() {

0 commit comments

Comments
 (0)