Add documentation to undocumented parameterless functions

umherirrender · WMDE bot · commit 9d11fc603795 · 2025-04-04T10:09:56.000Z
Parameterless function are not required to have the return value
documented, but it is best practice and may change (T272803)

Change-Id: I7f00ee837b53eaf9dfc2749810e0a82cd83c66f0
diff --git a/src/Diff/StatementListDiffer.php b/src/Diff/StatementListDiffer.php
@@ -36,7 +36,7 @@ public function getDiff( StatementList $fromStatements, StatementList $toStateme
 		);
 	}
 
-	private function newDiffer() {
+	private function newDiffer(): MapDiffer {
 		return new MapDiffer( false, null, new ComparableComparer() );
 	}
 
diff --git a/tests/fixtures/ItemFixtures.php b/tests/fixtures/ItemFixtures.php
@@ -11,7 +11,7 @@
  */
 class ItemFixtures {
 
-	public static function newItem() {
+	public static function newItem(): Item {
 		return new Item(
 			new ItemId( 'Q1' )
 		);
diff --git a/tests/fixtures/PropertyFixtures.php b/tests/fixtures/PropertyFixtures.php
@@ -11,7 +11,7 @@
  */
 class PropertyFixtures {
 
-	public static function newProperty() {
+	public static function newProperty(): Property {
 		return new Property(
 			new NumericPropertyId( 'P1' ),
 			null,

Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@ public function getDiff( StatementList $fromStatements, StatementList $toStateme`
`36`	`36`	`);`
`37`	`37`	`}`
`38`	`38`
`39`		`- private function newDiffer() {`
	`39`	`+ private function newDiffer(): MapDiffer {`
`40`	`40`	`return new MapDiffer( false, null, new ComparableComparer() );`
`41`	`41`	`}`
`42`	`42`