[Bug]: "bad math long / long long settings" when consuming wolfssl on arm32 android

[dg0yt]

Contact Details

No response

Version

5.8.4

Description

While trying to update port curl in vcpkg, I found this build error for vcpkg's arm-neon-android triplet:

FAILED: [code=1] lib/CMakeFiles/libcurl_static.dir/md5.c.o 
/android-ndk-r29/toolchains/llvm/prebuilt/linux-x86_64/bin/clang --target=armv7-none-linux-androideabi28 --sysroot=/android-ndk-r29/toolchains/llvm/prebuilt/linux-x86_64/sysroot -DBUILDING_LIBCURL -DCURL_HIDDEN_SYMBOLS -DECC_SHAMIR -DECC_TIMING_RESISTANT -DGCM_TABLE_4BIT -DHAVE_AESGCM -DHAVE_AES_KEYWRAP -DHAVE_ALPN -DHAVE_CERTIFICATE_STATUS_REQUEST -DHAVE_CERTIFICATE_STATUS_REQUEST_V2 -DHAVE_CHACHA -DHAVE_CONFIG_H -DHAVE_CRL -DHAVE_DH_DEFAULT_PARAMS -DHAVE_ECC -DHAVE_ENCRYPT_THEN_MAC -DHAVE_EXTENDED_MASTER -DHAVE_FFDHE_2048 -DHAVE_HASHDRBG -DHAVE_HKDF -DHAVE_HPKE -DHAVE_MAX_FRAGMENT -DHAVE_OCSP -DHAVE_ONE_TIME_AUTH -DHAVE_PKCS7 -DHAVE_POLY1305 -DHAVE_PTHREAD -DHAVE_SNI -DHAVE_SUPPORTED_CURVES -DHAVE_THREAD_LS -DHAVE_TLS_EXTENSIONS -DHAVE_TRUNCATED_HMAC -DHAVE_TRUSTED_CA -DHAVE_X963_KDF -DNO_DES3_TLS_SUITES -DNO_DSA -DNO_MD4 -DNO_OLD_TLS -DNO_PSK -DNO_RC4 -DOPENSSL_EXTRA -DTFM_ECC256 -DTFM_TIMING_RESISTANT -DWC_NO_ASYNC_THREADING -DWC_RSA_BLINDING -DWC_RSA_PSS -DWOLFSSL_AES_CFB -DWOLFSSL_AES_DIRECT -DWOLFSSL_ALLOW_ENCODING_CA_FALSE -DWOLFSSL_CERT_EXT -DWOLFSSL_CERT_GEN -DWOLFSSL_CERT_REQ -DWOLFSSL_ENCRYPTED_KEYS -DWOLFSSL_KEY_GEN -DWOLFSSL_NO_SHAKE128 -DWOLFSSL_NO_SHAKE256 -DWOLFSSL_OPTIONS_IGNORE_SYS -DWOLFSSL_PSS_LONG_SALT -DWOLFSSL_SHA384 -DWOLFSSL_SHA512 -DWOLFSSL_SYS_CA_CERTS -DWOLFSSL_TLS13 -DWOLFSSL_USE_ALIGN -DWOLF_CRYPTO_CB -I/mnt/vcpkg-ci/b/curl/src/c-8_19_0-3-dddc4aecab.clean/include -I/mnt/vcpkg-ci/b/curl/arm-neon-android-dbg/lib -I/mnt/vcpkg-ci/b/curl/src/c-8_19_0-3-dddc4aecab.clean/lib -isystem /mnt/vcpkg-ci/installed/arm-neon-android/include -g -DANDROID -fdata-sections -ffunction-sections -funwind-tables -fstack-protector-strong -no-canonical-prefixes -D_FORTIFY_SOURCE=2 -march=armv7-a -mthumb -Wformat -Werror=format-security  -fPIC   -fno-limit-debug-info    -fPIC -Werror-implicit-function-declaration -Wextra -Wall -Wpedantic -Wbad-function-cast -Wconversion -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wno-long-long -Wno-multichar -Wpointer-arith -Wshadow -Wsign-compare -Wundef -Wunused -Wwrite-strings -Waddress -Wattributes -Wcast-align -Wcast-qual -Wdeclaration-after-statement -Wdiv-by-zero -Wempty-body -Wendif-labels -Wfloat-equal -Wformat-security -Wignored-qualifiers -Wmissing-field-initializers -Wmissing-noreturn -Wno-padded -Wno-sign-conversion -Wno-switch-default -Wno-switch-enum -Wno-system-headers -Wold-style-definition -Wredundant-decls -Wstrict-prototypes -Wtype-limits -Wunreachable-code -Wunused-parameter -Wvla -Wconditional-uninitialized -Wno-used-but-marked-unused -Wshift-sign-overflow -Wshorten-64-to-32 -Wformat=2 -Wlanguage-extension-token -Wno-covered-switch-default -Wno-disabled-macro-expansion -Wformat-non-iso -Wenum-conversion -Wmissing-variable-declarations -Wno-documentation-unknown-command -Wsometimes-uninitialized -Wdouble-promotion -Wheader-guard -Wpragmas -Wunused-const-variable -Wcomma -Wassign-enum -Wextra-semi-stmt -Wimplicit-fallthrough -Wxor-used-as-pow -Wcast-function-type -Wreserved-identifier -Wno-reserved-macro-identifier -Wno-unsafe-buffer-usage -Wcast-function-type-strict -Wno-format-signedness -fvisibility=hidden -pthread -MD -MT lib/CMakeFiles/libcurl_static.dir/md5.c.o -MF lib/CMakeFiles/libcurl_static.dir/md5.c.o.d -o lib/CMakeFiles/libcurl_static.dir/md5.c.o -c /mnt/vcpkg-ci/b/curl/src/c-8_19_0-3-dddc4aecab.clean/lib/md5.c
In file included from /mnt/vcpkg-ci/b/curl/src/c-8_19_0-3-dddc4aecab.clean/lib/md5.c:76:
In file included from /mnt/vcpkg-ci/installed/arm-neon-android/include/wolfssl/openssl/md5.h:32:
In file included from /mnt/vcpkg-ci/installed/arm-neon-android/include/wolfssl/wolfcrypt/hash.h:29:
/mnt/vcpkg-ci/installed/arm-neon-android/include/wolfssl/wolfcrypt/types.h:1608:6: error: "bad math long / long long settings"
 1608 |     #error "bad math long / long long settings"
      |      ^
/mnt/vcpkg-ci/installed/arm-neon-android/include/wolfssl/wolfcrypt/types.h:1610:1: error: use of empty enum
 1610 | };
      | ^
2 errors generated.

There is a successful build of wolfssl, but the installed package doesn't allow a successful build of curl the arm32 android.

Reproduction steps

I can reproduce this locally with

vcpkg wolfssl:arm-neon-android  curl[core,wolfssl]:arm-neon-android

Relevant log output

[dg0yt]

What I found is that

• math long / long long settings depend on SIZEOF_LONG / SIZEOF_LONG_LONG,
• SIZEOF_LONG / SIZEOF_LONG_LONG depend on <limits.h> / HAVE_LIMITS_H,
• HAVE_LIMITS_H is available when building wolfssl, in config.h,
• HAVE_LIMITS_H is unknown when using wolfssl.

The following patch solves the issue.

diff --git a/cmake/config.in b/cmake/config.in
index f2524e4..6054b6d 100644
--- a/cmake/config.in
+++ b/cmake/config.in
@@ -19,9 +19,6 @@
 /* Define to 1 if you have the `gmtime_r' function. */
 #cmakedefine HAVE_GMTIME_R @HAVE_GMTIME_R@
 
-/* Define to 1 if you have the <limits.h> header file. */
-#cmakedefine HAVE_LIMITS_H @HAVE_LIMITS_H@
-
 /* Define to 1 if you have the <pcap/pcap.h> header file. */
 #cmakedefine HAVE_PCAP_PCAP_H @HAVE_PCAP_PCAP_H@
 
diff --git a/cmake/options.h.in b/cmake/options.h.in
index 7446b1b..615cc9b 100644
--- a/cmake/options.h.in
+++ b/cmake/options.h.in
@@ -122,6 +122,8 @@ extern "C" {
 #cmakedefine HAVE_KEYING_MATERIAL
 #undef HAVE_LIBOQS
 #cmakedefine HAVE_LIBOQS
+#undef HAVE_LIMITS_H
+#cmakedefine HAVE_LIMITS_H @HAVE_LIMITS_H@
 #undef HAVE_MAX_FRAGMENT
 #cmakedefine HAVE_MAX_FRAGMENT
 #undef HAVE_OCSP

But it would be the first HAVE_<foo_h> in options.h, so I'm not sure if this is the right approach.

Fixing this is somehwat relevant to being able to update vcpkg port curl after tomorrow's release.

[kareem-wolfssl]

Hi @dg0yt,

Thanks for the report. I will review this with the team later today to determine the best approach on this.
In the meantime, please try manually defining SIZEOF_LONG and SIZEOF_LONG_LONG in your build settings and let me know if it helps unblock you for now.

[dg0yt]

In the meantime, please try manually defining SIZEOF_LONG and SIZEOF_LONG_LONG in your build settings and let me know if it helps unblock you for now.

Thanks, but AFAIU this advice may fit for customized, specific wolfssl builds. I'm dealing with vcpkg ports, i.e. portable build recipes. In this world, port wolfssl shall make available such settings it determined at build time to downstream consumers - that's my "build settings".

What unblocks me right now is the reported change. (Now confirmed in vcpkg CI.)
But I acknowledge that wolfssl shouldn't take more general macro names without namespace/prefix.