This repository was archived by the owner on Mar 4, 2026. It is now read-only.
Add semantic nullability capability to async-graphql#104
Merged
abliskovsky-agilebits merged 5 commits intomainfrom Mar 2, 2026
Merged
Add semantic nullability capability to async-graphql#104abliskovsky-agilebits merged 5 commits intomainfrom
abliskovsky-agilebits merged 5 commits intomainfrom
Conversation
ipetkov
approved these changes
Feb 26, 2026
| if cfg!(feature = "nullable-result") { | ||
| match semantic_nullability { | ||
| SemanticNullability::None => SemanticNullability::None, | ||
| SemanticNullability::OutNonNull => SemanticNullability::InNonNull, |
Collaborator
There was a problem hiding this comment.
Just curious, is this load bearing and if so what does it mean?
I suppose the match statement wouldn't be there if this wasn't needed but I haven't groked why
Collaborator
Author
There was a problem hiding this comment.
This appears to be a hack to extend semantic nullability to the members of the list. Without it, it would be ok for the list to be null but not the members of the list to be null.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
nullable-resultandsemanticNonNullbranches are somewhat out of date on the remote, so this MR updates them to work with our latest async-graphqlThe original MR is here: async-graphql/async-graphql#1638