Skip to content

fix(ci): various lint fixes to unblock CI#48

Merged
hipstersmoothie merged 2 commits intoATProtocol-Community:mainfrom
grishaLR:glr/fix-lint
May 7, 2026
Merged

fix(ci): various lint fixes to unblock CI#48
hipstersmoothie merged 2 commits intoATProtocol-Community:mainfrom
grishaLR:glr/fix-lint

Conversation

@grishaLR
Copy link
Copy Markdown
Contributor

@grishaLR grishaLR commented May 6, 2026

overview

this PR has various fixes to get the lint step to pass in CI

  • discover-listing-oauth-metadata.ts — fix import order; rename input param → opts (no-shadow); flip negated condition; remove ?? {} spread fallback
  • oauth-discovery-local-progress.ts — rename catch (e) → catch (error)
  • sync-listing-oauth-probes.ts — rename catch (e) → catch (error); eliminate report! non-null assertion; .at(-1) instead of [length - 1]
  • schema.ts — swap two import lines to alphabetical order
  • api-admin.functions.ts — move toIso helper from inside handler to module scope
  • oauth-authorization-page-discovery.ts — for...of entries() to eliminate targets[i]! non-null assertion
  • oauth-listing-playwright-discovery.ts — .textContent() instead of .innerText(); wrap callback reference in arrow function
  • oauth-url-gaps.tsx — reorder StyleX properties: logical longhands (textAlign, whiteSpace, verticalAlign) before physical longhands (border*, padding*)

@grishaLR grishaLR requested a review from hipstersmoothie May 6, 2026 20:36
@hipstersmoothie hipstersmoothie merged commit ac85f5e into ATProtocol-Community:main May 7, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants