[Scala 3] drop deprecated Sam / SamCompanion#863
Open
halotukozak wants to merge 2 commits into
Open
Conversation
halotukozak
changed the title
halotukozak
changed the title
- Delete core/src/main/scala/com/avsystem/commons/misc/Sam.scala (@deprecated since 2.28.0) - Delete core/src/main/scala/com/avsystem/commons/misc/SamCompanion.scala (@deprecated since 2.28.0) - Delete corresponding test SamTest.scala - Stdlib native SAM conversion (Scala 2.12+) supersedes; no Scala 3 port per project rule feedback_dont_port_deprecated.md - Zero non-self references in core/, mongo/, hocon/
- Add §1 (Will Not Migrate) row for misc.Sam / misc.SamCompanion - Remove §6 Backlog rows for Sam.scala:9, SamCompanion.scala:11, SamCompanion.scala:19 - Decrement Total tags: 155 -> 153
halotukozak
force-pushed
the
02-05-drop-sam
branch
from
cac74d1 to
cf95018
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Drops deprecated
misc.Sam/misc.SamCompanioninstead of porting them to Scala 3.@deprecated since 2.28.0with stdlib native SAM conversion as the documented replacement (val r: Runnable = () => doStuff()etc.).feedback_dont_port_deprecated.md: skip@deprecatedAPIs that have stdlib replacements.core/,mongo/,hocon/— clean delete.Changes
core/src/main/scala/com/avsystem/commons/misc/Sam.scalacore/src/main/scala/com/avsystem/commons/misc/SamCompanion.scalacore/src/test/scala/com/avsystem/commons/misc/SamTest.scalaMIGRATION.md§1 (Will Not Migrate): add entry formisc.Sam/misc.SamCompanionMIGRATION.md§6 (Backlog): remove 3 rows (Sam.scala:9, SamCompanion.scala:11, SamCompanion.scala:19);Total tags: 155 → 153Test plan
grep -rnE '\\b(Sam|SamCompanion)\\b' core/ mongo/ hocon/returns zero non-self matchescore/,mongo/,hocon/— pure deletion cannot break compile