Skip to content

Fix building shared libraries on Windows using MinGW64 - #3075

Merged
jstone-lucasfilm merged 3 commits into
AcademySoftwareFoundation:mainfrom
SavaLione:fix/mingw64-shared-libs
Sep 17, 2026
Merged

jstone-lucasfilm merged 3 commits into
AcademySoftwareFoundation:mainfrom
SavaLione:fix/mingw64-shared-libs

Conversation

@SavaLione

Copy link
Copy Markdown
Contributor

Summary

Hi,
There was an issue to building MaterialX on a Windows system using the MinGW64 compiler:

This PR fixes this compilation issue, and the dynamical libraries are now successfully build.

The referenced issue suggests the addition of new GitHub CI entries.
However, this PR does not include them.
I can work on the CI implementation if it is still required and the additional information is provided:

  • How is it acceptable get the MinGW binaries (e.g., whether binaries provided by Stephan T. Lavavej are acceptable)
  • Which additional tools may a container download and use (is it possible to use bash or ninja?)
  • What is the preferred way to cache these binaries?

Tests

Tests were successfully compiled and executed.
All 94 tests cases passed (39629 assertions).

Signed-off-by: Savelii Pototskii <savelii.pototskii@gmail.com>
@linux-foundation-easycla

linux-foundation-easycla Bot commented Sep 16, 2026

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: SavaLione / name: Savelii Pototskii (c64c955)

@jstone-lucasfilm

Copy link
Copy Markdown
Member

Thanks for this proposal, @SavaLione! Can you add a comment on the GitHub Issue that you're tackling, so that we can assign it to you? Additionally, see the instructions at #3075 (comment) on how to resolve the CLA authorization warnings, so that we can begin reviewing this PR.

@SavaLione

Copy link
Copy Markdown
Contributor Author

The CLA was signed via EasyCLA, a comment was also added to the issue

@jstone-lucasfilm

Copy link
Copy Markdown
Member

Apologies, @SavaLione, another developer requested this one first, but feel free to request any other unclaimed issue for Dev Days.

Signed-off-by: Savelii Pototskii <savelii.pototskii@gmail.com>
@SavaLione

Copy link
Copy Markdown
Contributor Author

Yeah, sure, I should've checked the full issue conversation earlier.
It still may be useful to the person who initially requested this issue first.
And there a new workflow has to be added, so the current PR is not fully covering all requirements from the issue.

@jstone-lucasfilm

Copy link
Copy Markdown
Member

Thanks for understanding, @SavaLione, and indeed the other developer may find this work useful for their task. I've added a few more Good First Issues to our list for Dev Days, if you'd like to take on another task for the event tomorrow.

@cod1r

cod1r commented Sep 17, 2026

Copy link
Copy Markdown

I think I will add to this PR and finish out the CI stuff if that's ok.

I don't want to throw away mister Sava's good work here :)

@jstone-lucasfilm

Copy link
Copy Markdown
Member

Much appreciated, @cod1r, and I think that's a great path forward.

@jstone-lucasfilm jstone-lucasfilm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks correct to me, thanks @SavaLione, and let's move forward with the merge, so that the next steps proposed in #3081 can be validated.

@jstone-lucasfilm
jstone-lucasfilm merged commit 40ec3dc into AcademySoftwareFoundation:main Sep 17, 2026
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants