Fix building shared libraries on Windows using MinGW64 - #3075
jstone-lucasfilm merged 3 commits into
Conversation
Signed-off-by: Savelii Pototskii <savelii.pototskii@gmail.com>
|
|
|
Thanks for this proposal, @SavaLione! Can you add a comment on the GitHub Issue that you're tackling, so that we can assign it to you? Additionally, see the instructions at #3075 (comment) on how to resolve the CLA authorization warnings, so that we can begin reviewing this PR. |
|
The CLA was signed via EasyCLA, a comment was also added to the issue |
|
Apologies, @SavaLione, another developer requested this one first, but feel free to request any other unclaimed issue for Dev Days. |
Signed-off-by: Savelii Pototskii <savelii.pototskii@gmail.com>
|
Yeah, sure, I should've checked the full issue conversation earlier. |
|
Thanks for understanding, @SavaLione, and indeed the other developer may find this work useful for their task. I've added a few more Good First Issues to our list for Dev Days, if you'd like to take on another task for the event tomorrow. |
|
I think I will add to this PR and finish out the CI stuff if that's ok. I don't want to throw away mister Sava's good work here :) |
|
Much appreciated, @cod1r, and I think that's a great path forward. |
jstone-lucasfilm
left a comment
There was a problem hiding this comment.
This change looks correct to me, thanks @SavaLione, and let's move forward with the merge, so that the next steps proposed in #3081 can be validated.
40ec3dc
into
AcademySoftwareFoundation:main
Summary
Hi,
There was an issue to building MaterialX on a Windows system using the MinGW64 compiler:
This PR fixes this compilation issue, and the dynamical libraries are now successfully build.
The referenced issue suggests the addition of new GitHub CI entries.
However, this PR does not include them.
I can work on the CI implementation if it is still required and the additional information is provided:
Tests
Tests were successfully compiled and executed.
All 94 tests cases passed (39629 assertions).