-
Notifications
You must be signed in to change notification settings - Fork 730
CustomTabs web api for plugins #1785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @RohitKushvaha01, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new Cordova plugin that integrates Android Custom Tabs functionality, allowing applications to open external web links within a customizable, browser-like interface. This enhancement provides a smoother user experience by keeping users within the app's context while leveraging the full capabilities and security of their default browser, and also addresses issue #1757. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new Cordova plugin for using Custom Tabs, which is a great addition for displaying web content within the app. The implementation is solid, but I've found a couple of areas for improvement in the native Java code. Specifically, I'm suggesting to avoid hardcoding the browser to Chrome to provide a better experience for all users, and to use a non-deprecated API for setting the title visibility. My review comment includes a code suggestion to address these points. The rest of the plugin setup and JavaScript bridge look good.
This comment has been minimized.
This comment has been minimized.
|
Preview Release for this, has been built. |
UnschooledGamer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR introduces a Custom Tabs API that uses the device’s default browser to open web pages without leaving Acode.
While this is not a WebView and does not offer deep DOM or JavaScript control, it provides a lightweight and reliable way to open external links inside the app context. The implementation can be extended in the future to support features such as browser warm-up, custom tab sizing, and adding or removing menu items and making the tab full screen.
Closes #1757
Usage