Skip to content

fix(notify): restore notification text from PR #223 while keeping icon fix from PR #227 - #232

Open
TimeToBuildBob wants to merge 1 commit into
ActivityWatch:masterfrom
TimeToBuildBob:fix/notification-text-revert
Open

fix(notify): restore notification text from PR #223 while keeping icon fix from PR #227#232
TimeToBuildBob wants to merge 1 commit into
ActivityWatch:masterfrom
TimeToBuildBob:fix/notification-text-revert

Conversation

@TimeToBuildBob

Copy link
Copy Markdown
Contributor

Problem

PR #227 accidentally reverted user-friendly text changes from PR #223 while adding the notification icon fix.

Notification text was changed from the clean version:

  • 'ActivityWatch' → 'ActivityWatch Server' ❌
  • 'Running in the background' → 'Server and sync running in background' ❌

But the icon fix (using ic_stat_notification) should be preserved.

Solution

Restore the notification text improvements from PR #223 while keeping the icon fix from PR #227.

The final notification now has:

  • Clean, user-friendly title: 'ActivityWatch' ✓
  • Clear description: 'Running in the background' ✓
  • Proper notification icon: ic_stat_notification ✓

Related

Fixes #226

…e keeping icon fix from PR ActivityWatch#227

PR ActivityWatch#227 accidentally reverted the user-friendly text changes from PR ActivityWatch#223:
- 'ActivityWatch Server' -> 'ActivityWatch'
- 'Server and sync running in background' -> 'Running in the background'

The icon fix from ActivityWatch#227 (using ic_stat_notification) is preserved.

Fixes ActivityWatch#226
@greptile-apps

greptile-apps Bot commented Aug 20, 2026

Copy link
Copy Markdown

Greptile Summary

Restores the concise foreground-service notification title and description while preserving the dedicated status-bar icon.

  • Changes the notification title to “ActivityWatch”.
  • Changes the notification body to “Running in the background”.
  • Leaves ic_stat_notification unchanged.

Confidence Score: 5/5

The PR appears safe to merge, with no actionable correctness, security, or quality issues identified.

The change is limited to two static notification strings and preserves the existing foreground-service construction, pending intent, channel, and valid status-bar icon.

Important Files Changed

Filename Overview
mobile/src/main/java/net/activitywatch/android/BackgroundService.kt Updates only the foreground-service notification’s static title and body text without altering service behavior or icon handling.

Reviews (1): Last reviewed commit: "fix(notify): restore notification text f..." | Re-trigger Greptile

@TimeToBuildBob

Copy link
Copy Markdown
Contributor Author

CI-green and mergeable (Greptile 5/5) — waiting only on a maintainer click.

This PR is ready to merge, but the bot has pull-only access to this repo and can't self-merge — surfacing it here so it isn't lost. The monitoring loop will stop re-flagging it now that this note is posted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Notifications don't display AW icon

1 participant