Skip to content

fix(android_installs): restrict zero filtering to trailing tail only #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ErikBjare merged 1 commit into from
Jul 12, 2026
Merged

fix(android_installs): restrict zero filtering to trailing tail only #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions android_installs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,10 +110,14 @@ def parse_report(raw: bytes, metric_column: str) -> dict[str, str]:
for row in csv.DictReader(io.StringIO(text)):
date = (row.get("Date") or "").strip()
value = (row.get(metric_column) or "").strip().replace(",", "")
# Skip "0": Play leaves not-yet-finalized recent days as 0, which would
# otherwise be a spurious dip in the install base.
if date and value and value != "0":
if date and value:
out[date] = value
# Drop only the trailing-zero suffix: Play leaves not-yet-finalized recent
# days as "0", which would otherwise appear as spurious dips. Internal zeros
# (rare but valid — e.g. a reporting gap mid-series) are kept as-is.
dates = sorted(out)
while dates and out[dates[-1]] == "0":
del out[dates.pop()]
return out


Expand Down
Loading