fix: replace bare except with except Exception#1308
Open
YouFoxGirl wants to merge 2 commits intoAgentOps-AI:mainfrom
Open
fix: replace bare except with except Exception#1308YouFoxGirl wants to merge 2 commits intoAgentOps-AI:mainfrom
YouFoxGirl wants to merge 2 commits intoAgentOps-AI:mainfrom
Conversation
- **bare_except**: Replaced bare except: with except Exception: - **bare_except**: Replaced bare except: with except Exception: - **bare_except**: Replaced bare except: with except Exception: - **bare_except**: Replaced bare except: with except Exception: - **bare_except**: Replaced bare except: with except Exception: - **bare_except**: Replaced bare except: with except Exception: - **bare_except**: Replaced bare except: with except Exception: - **bare_except**: Replaced bare except: with except Exception: - **bare_except**: Replaced bare except: with except Exception: - **bare_except**: Replaced bare except: with except Exception: - **bare_except**: Replaced bare except: with except Exception: - **bare_except**: Replaced bare except: with except Exception: - **bare_except**: Replaced bare except: with except Exception: - **bare_except**: Replaced bare except: with except Exception: - **bare_except**: Replaced bare except: with except Exception: - **bare_except**: Replaced bare except: with except Exception: - **bare_except**: Replaced bare except: with except Exception: - **bare_except**: Replaced bare except: with except Exception: - **bare_except**: Replaced bare except: with except Exception: - **sync_sleep_in_async**: Replaced time.sleep() with asyncio.sleep() in async functions - **sync_sleep_in_async**: Replaced time.sleep() with asyncio.sleep() in async functions - **sync_sleep_in_async**: Replaced time.sleep() with asyncio.sleep() in async functions
Use except Exception: instead of bare except: to avoid catching KeyboardInterrupt and SystemExit.
YouFoxGirl
force-pushed
the
foxclaw/fix-2026-03-21T23-18-37
branch
from
609dc0e to
bf08ea9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Replace bare
except:clauses withexcept Exception:to avoid catchingKeyboardInterruptandSystemExit. Added a TODO note for futuremore specific exception handling where applicable.
Why this matters
Bare
except:catches all exceptions includingKeyboardInterruptand
SystemExit, which can hide bugs and make debugging harder.