Skip to content

Fix JSON file error handling - #2513

Open
pratyushsinghal7 wants to merge 1 commit into
AlaSQL:developfrom
pratyushsinghal7:issue-1314
Open

Fix JSON file error handling#2513
pratyushsinghal7 wants to merge 1 commit into
AlaSQL:developfrom
pratyushsinghal7:issue-1314

Conversation

@pratyushsinghal7

Copy link
Copy Markdown
Contributor

Fixes #1314

Summary

  • pass JSON file-loading failures to the query error callback
  • route malformed JSON parse failures through the same error path
  • add regression coverage for callbacks and lazy promises

Testing

  • bun test --preload ./test/bun-setup.js ./test/test1314.js (3 passed)
  • bun run test-only (2191 passed, 213 skipped, 0 failed)
  • bun x prettier --check src/84from.js test/test1314.js

@mathiasrw

Copy link
Copy Markdown
Member

Very smooth. Thank you!

@mathiasrw

Copy link
Copy Markdown
Member

As it might break existing functionality we will merge it on next major version bump

@mathiasrw mathiasrw added this to the Next major version bump milestone Aug 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

error callback is undefined

2 participants