Skip to content

ITSMFT: share tracking slab allocation primitives - #15730

Merged
shahor02 merged 7 commits into
AliceO2Group:devfrom
mpuccio:itsmft-tracking-precursor
Sep 2, 2026
Merged

ITSMFT: share tracking slab allocation primitives#15730
shahor02 merged 7 commits into
AliceO2Group:devfrom
mpuccio:itsmft-tracking-precursor

Conversation

@mpuccio

@mpuccio mpuccio commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@mpuccio
mpuccio requested a review from davidrohr as a code owner August 27, 2026 21:21
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2/fullCI_slc9 for 9f24e0b at 2026-08-28 02:26:

## sw/BUILD/QualityControl-latest/log
/sw/SOURCES/QualityControl/v1.195.1/v1.195.1/Modules/ITS/src/ITSTrackTask.cxx:28:10: fatal error: ITStracking/Constants.h: No such file or directory
ninja: build stopped: cannot make progress due to previous errors.

Full log here.

@f3sch f3sch left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is mostly noise from bounded_vector to o2::itsmft::tracking::bounded_vector where a using decl. would have sufficed. This is fine I guess. See some comments below.
Changed the header include in AliceO2Group/QualityControl#2687

Comment thread Detectors/ITSMFT/common/tracking/src/BoundedAllocator.cxx Outdated
Comment thread Detectors/ITSMFT/common/tracking/include/ITSMFTTracking/CapacityEstimator.h Outdated
Comment thread Detectors/ITSMFT/common/tracking/src/CapacityEstimator.cxx Outdated
Comment thread Detectors/ITSMFT/ITS/tracking/test/CMakeLists.txt Outdated
Comment thread Detectors/ITSMFT/common/tracking/include/ITSMFTTracking/SlabBumpAllocator.h Outdated
@alibuild

alibuild commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2/fullCI_slc9 for 3df7d03 at 2026-09-01 12:16:

## sw/BUILD/O2Physics-latest/log
c++: fatal error: Killed signal terminated program cc1plus
c++: fatal error: Killed signal terminated program cc1plus
c++: fatal error: Killed signal terminated program cc1plus
c++: fatal error: Killed signal terminated program cc1plus
ninja: build stopped: subcommand failed.


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
grep: error-log.txt: binary file matches
++ GRERR=1
++ [[ 1 == 0 ]]
++ mkdir -p /sw/INSTALLROOT/51df1f2d4fc3c69009e5a6b503b8322332a2da11/slc9_x86-64/o2checkcode/1.0-local92/etc/modulefiles
++ alibuild-generate-module
+ HAS_BIN=
+ HAS_LIB=
+ HAS_CMAKE=
+ HAS_ROOT=
+ '[' 0 '!=' 0 ']'
+ cat
+ printf 'if ![ is-loaded '\''BASE/1.0'\'' ] {\n module load BASE/1.0\n}'
+ echo 'BUILD_REQUIRES=CMake alibuild-recipe-tools defaults-release'
BUILD_REQUIRES=CMake alibuild-recipe-tools defaults-release
+ FULL_BUILD_REQUIRES='Alice-GRID-Utils pytorch_cpuinfo googlebenchmark json-c date FairCMakeModules MPFR Python-modules-list CMake double-conversion ninja-fortran safe_int alibuild-recipe-tools ninja UUID defaults-release bz2 O2-customization'
+ echo 'FULL_BUILD_REQUIRES=Alice-GRID-Utils pytorch_cpuinfo googlebenchmark json-c date FairCMakeModules MPFR Python-modules-list CMake double-conversion ninja-fortran safe_int alibuild-recipe-tools ninja UUID defaults-release bz2 O2-customization'
FULL_BUILD_REQUIRES=Alice-GRID-Utils pytorch_cpuinfo googlebenchmark json-c date FairCMakeModules MPFR Python-modules-list CMake double-conversion ninja-fortran safe_int alibuild-recipe-tools ninja UUID defaults-release bz2 O2-customization
++ env
++ cut -f1 -d=
++ grep -v '^DEFAULT_'
++ grep -v PKGREVISION
++ grep -v ALIBUILD_RECIPE_TOOLS
++ grep REVISION
++ sed -e s/_REVISION//
+ for x in $(env | cut -f1 -d= | grep -v "^DEFAULT_" | grep -v PKGREVISION | grep -v ALIBUILD_RECIPE_TOOLS | grep REVISION | sed -e 's/_REVISION//')
++ eval 'echo $LIBFFI_REVISION'
+++ echo 14
+ REVISION_VALUE=14
++ eval 'echo $LIBFFI_VERSION'
+++ echo v3.2.1-alice1
+ VERSION_VALUE=v3.2.1-alice1
++ eval 'echo $LIBFFI_ROOT'
+++ echo /sw/slc9_x86-64/libffi/v3.2.1-alice1-14
+ ROOT_PATH_VALUE=/sw/slc9_x86-64/libffi/v3.2.1-alice1-14
+ '[' -z 14 ']'
[0 more errors; see full log]

Full log here.

@f3sch

f3sch commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

@shahor02 I think this can be merged

@shahor02 shahor02 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the reason of ITStracking/TrackingConfigParam.h -> ITSMFTTracking/ITSTrackingConfigParam.h move? These params are still specific for ITS only right (and temporarily for the ALICE3).

@f3sch

f3sch commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

What was the reason of ITStracking/TrackingConfigParam.h -> ITSMFTTracking/ITSTrackingConfigParam.h move? These params are still specific for ITS only right (and temporarily for the ALICE3).

I imagined that @mpuccio wants to template it for the MFT parameters but Max should confirm

@shahor02 shahor02 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, merging, can be changed later, if needed.

@shahor02
shahor02 merged commit e4eaccd into AliceO2Group:dev Sep 2, 2026
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants