Skip to content

[Common] Add safety against missing ZvtxProfile and add INEL > 0 requirement - #17608

Merged
ddobrigk merged 5 commits into
masterfrom
romainschotter-patch-2
Aug 27, 2026
Merged

[Common] Add safety against missing ZvtxProfile and add INEL > 0 requirement#17608
ddobrigk merged 5 commits into
masterfrom
romainschotter-patch-2

Conversation

@romainschotter

@romainschotter romainschotter commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator
  • Add safety against missing ZvtxProfile (allow to run without the Z-vtx equalization being available)
  • Add INEL > 0 requirement

@ddobrigk @jesgum for your information

@romainschotter
Add safety against missing ZvtxProfile and add INEL > 0 requirement
701150f 
Added a new configurable option to require INEL > 0 and updated related logic in collision selection.
@github-actions github-actions Bot changed the title Add safety against missing ZvtxProfile and add INEL > 0 requirement [Common] Add safety against missing ZvtxProfile and add INEL > 0 requirement Aug 26, 2026
@github-actions

github-actions Bot commented Aug 26, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@alibuild alibuild mentioned this pull request Aug 26, 2026
Merged
@romainschotter
romainschotter marked this pull request as ready for review August 26, 2026 11:37
@alibuild

alibuild commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for b1aef84 at 2026-08-26 13:47:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/Common/Tasks/centralityStudy.cxx:771:29: error: 'requireINELgtZERO' was not declared in this scope
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/Common/Tasks/centralityStudy.cxx:937:16: error: expected primary-expression before ',' token
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/Common/Tasks/centralityStudy.cxx:778:70: error: the address of 'passINELgtZERO' will never be NULL [-Werror=address]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/Common/Tasks/centralityStudy.cxx:778:73: error: label 'passINELgtZERO' used but not defined
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/Common/Tasks/centralityStudy.cxx:778:70: error: the address of 'passINELgtZERO' will never be NULL [-Werror=address]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/Common/Tasks/centralityStudy.cxx:778:73: error: label 'passINELgtZERO' used but not defined
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/Common/Tasks/centralityStudy.cxx:778:70: error: the address of 'passINELgtZERO' will never be NULL [-Werror=address]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/Common/Tasks/centralityStudy.cxx:778:73: error: label 'passINELgtZERO' used but not defined
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/Common/Tasks/centralityStudy.cxx:778:70: error: the address of 'passINELgtZERO' will never be NULL [-Werror=address]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/Common/Tasks/centralityStudy.cxx:778:73: error: label 'passINELgtZERO' used but not defined
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

alibuild commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for b1aef84 at 2026-08-26 16:46:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/Common/Tasks/centralityStudy.cxx:771:29: error: 'requireINELgtZERO' was not declared in this scope
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/Common/Tasks/centralityStudy.cxx:937:16: error: expected primary-expression before ',' token
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/Common/Tasks/centralityStudy.cxx:778:73: error: label 'passINELgtZERO' used but not defined
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/Common/Tasks/centralityStudy.cxx:778:73: error: label 'passINELgtZERO' used but not defined
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/Common/Tasks/centralityStudy.cxx:778:73: error: label 'passINELgtZERO' used but not defined
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/Common/Tasks/centralityStudy.cxx:778:73: error: label 'passINELgtZERO' used but not defined
ninja: build stopped: subcommand failed.

Full log here.

@ddobrigk
ddobrigk merged commit 19763e1 into master Aug 27, 2026
15 checks passed
@ddobrigk
ddobrigk deleted the romainschotter-patch-2 branch August 27, 2026 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ddobrigk ddobrigk ddobrigk approved these changes
@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner
@jgrosseo jgrosseo Awaiting requested review from jgrosseo jgrosseo is a code owner
@iarsene iarsene Awaiting requested review from iarsene iarsene is a code owner
@ktf ktf Awaiting requested review from ktf ktf is a code owner
@dsekihat dsekihat Awaiting requested review from dsekihat dsekihat is a code owner

Assignees

No one assigned

Labels

common

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@romainschotter @alibuild @ddobrigk