Skip to content

Viewsheds in tests/benchmarks are rotated differently for CPU kernel #53

Description

@tombh

The tests want the rotation offset by -45 and the benchmarks want the tests offset by -90. Why?

Activity

  1. ryan-berger commented on Apr 22, 2026

    @ryan-berger
    Member

    The -90 makes some sense. My rotation tests show that at 0 degrees we're now pointing downwards.

    -45 is a mystery to me though....

  2. tombh commented on Apr 22, 2026

    @tombh
    CollaboratorAuthor

    I think it's more likely that the crude ASCII display of the viewsheds in the unit tests is more likely the culprit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions