fix: ensure POSIX path serialization for workflow scriptPath on Windows#5
Open
Adityakk9031 wants to merge 1 commit into
Open
fix: ensure POSIX path serialization for workflow scriptPath on Windows#5Adityakk9031 wants to merge 1 commit into
Adityakk9031 wants to merge 1 commit into
Conversation
### Description This PR addresses an issue where Claude-style Workflow tool payloads fail to resolve correctly when dispatched from a Windows host. Previously, `Workflow.native_input()` serialized the `scriptPath` using `str(self.script_path)`, which evaluates to backslash-separated paths on Windows (e.g., `workflows\audit-routes.js`). When sent to the Claude API backend, these backslashes are often interpreted as literal characters in a filename rather than directory separators, causing workflow scripts to fail to load. This change updates the serialization to explicitly use `self.script_path.as_posix()`, enforcing forward slashes on all operating systems and ensuring seamless compatibility with cloud APIs. ### Testing - [x] Verified that `pytest tests/test_workflows.py::test_file_workflow_requires_native_workflow_feature` now passes on Windows, confirming the correct payload structure is generated. ### Related Issues Fixes #[Insert Issue Number Here]
Author
|
@divitsheth have a look |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses an issue where Claude-style Workflow tool payloads fail to resolve correctly when dispatched from a Windows host.
Previously,
Workflow.native_input()serialized thescriptPathusingstr(self.script_path), which evaluates to backslash-separated paths on Windows (e.g.,workflows\audit-routes.js). When sent to the Claude API backend, these backslashes are often interpreted as literal characters in a filename rather than directory separators, causing workflow scripts to fail to load.This change updates the serialization to explicitly use
self.script_path.as_posix(), enforcing forward slashes on all operating systems and ensuring seamless compatibility with cloud APIs.Testing
pytest tests/test_workflows.py::test_file_workflow_requires_native_workflow_featurenow passes on Windows, confirming the correct payload structure is generated.Related Issues
Fixes #4