Skip to content

Workflow tweaking#1802

Merged
ivarne merged 2 commits into
feature/set-data-field-by-expressionfrom
chore/workflow-tweaks
Jun 9, 2026
Merged

Workflow tweaking#1802
ivarne merged 2 commits into
feature/set-data-field-by-expressionfrom
chore/workflow-tweaks

Conversation

@ivarne

@ivarne ivarne commented Jun 8, 2026

Copy link
Copy Markdown
Member

Run tests on all PRs, but only check labels on main and release.

Tested by opening the PR against another branch to see that label check did not run, but tests did.

Summary by CodeRabbit

  • Chores
    • Updated pull request workflow configurations to restrict checks to specific branches and event types, optimizing continuous integration pipeline efficiency.

Run tests on all PRs, but only check labels on main and release.
Copilot AI review requested due to automatic review settings June 8, 2026 21:36
@coderabbitai

coderabbitai Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c4773977-a1ac-4fa4-a3cc-bca86df7c722

📥 Commits

Reviewing files that changed from the base of the PR and between b86fb54 and c3e73d2.

📒 Files selected for processing (2)
  • .github/workflows/check-label-added.yml
  • .github/workflows/dotnet-test.yml

📝 Walkthrough

Walkthrough

Two GitHub Actions workflows are refined to apply more selective filtering: the label check workflow now targets only main and release/** branches, while the dotnet test workflow specifies explicit pull request event types and conditionally skips analysis runs triggered by PR metadata edits.

Changes

CI Workflow Trigger Refinement

Layer / File(s) Summary
Label check branch filtering
​.github/workflows/check-label-added.yml
The pull_request trigger is restricted to run only when PRs target main or release/** branches.
Test analysis event type and job filtering
​.github/workflows/dotnet-test.yml
The pull_request trigger is updated to listen explicitly for opened, synchronize, reopened, and edited actions, and the analyze job is guarded to skip execution on edited events unless the PR's base branch reference is available.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

  • Altinn/app-lib-dotnet#1771: Updates the same label check workflow to refine how pull requests targeting main and release branches are handled.

Suggested reviewers

  • martinothamar
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Workflow tweaking' is vague and generic, using a non-descriptive term that doesn't convey the specific nature of the changes made to the workflows. Use a more descriptive title that highlights the main change, such as 'Restrict label check to main and release branches' or 'Adjust CI workflows to run tests on all PRs'.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/workflow-tweaks

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts GitHub Actions workflow triggers so that CI tests run for every pull request, while the “Label Check” workflow only runs for PRs targeting main or release/**.

Changes:

  • Removed the pull_request.branches filter from dotnet-test.yml so tests run on all PRs.
  • Added a pull_request.branches filter to check-label-added.yml so label enforcement only applies to PRs into main and release/**.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/dotnet-test.yml Expands test workflow execution to all pull requests by removing branch filtering.
.github/workflows/check-label-added.yml Restricts label-check workflow to PRs targeting main and release/**.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ivarne ivarne changed the base branch from feature/set-data-field-by-expression to main June 8, 2026 21:37
@ivarne ivarne changed the base branch from main to feature/set-data-field-by-expression June 8, 2026 21:55
@sonarqubecloud

sonarqubecloud Bot commented Jun 8, 2026

Copy link
Copy Markdown

@ivarne ivarne merged commit fa24d2a into feature/set-data-field-by-expression Jun 9, 2026
18 checks passed
@ivarne ivarne deleted the chore/workflow-tweaks branch June 9, 2026 07:10
@coderabbitai coderabbitai Bot mentioned this pull request Jun 9, 2026
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants