Return None from detect_mime for non-bytes input #758
Merged
+33
−21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
W this pr
detect_mimereturnsNoneif the inputs are notbytesinstead of raising an error.It already returns
Noneif no mimetype was found in the bytes input.I noticed I was doing checks for
isinstance(data, bytes)or putting it in atry/exceptblock when using this function and I figured it might be better to handle this case in here instead.