fix(ios): rotate loop animation not working on iOS#33
Merged
janicduplessis merged 1 commit intomainfrom Apr 8, 2026
Merged
Conversation
The fix in #25 added individual key-path animations for transform sub-properties to handle rotate 0→360, but the gate condition (`hasInitialTransform`) still compared composed CATransform3D matrices. Since cos(2π) = cos(0), the matrices for 0° and 360° are identical, so the animation block was never entered. Move the raw prop value bitmask computation before the gate and use it to determine `hasInitialTransform`, ensuring rotate 0→360 (and any other equivalent-matrix cases) are correctly detected as changes. Closes #21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The fix in #25 added individual key-path animations for transform sub-properties to correctly handle rotate 0→360° with loop. However, the gate condition (
hasInitialTransform) still compared composedCATransform3Dmatrices. Sincecos(2π) = cos(0), the matrices for 0° and 360° are mathematically identical, sohasInitialTransformwas alwaysNOand the animation block was never entered.Solution
Move the raw prop value bitmask computation (
changedInitTransform) before the gate and usechangedInitTransform != 0to determinehasInitialTransform. This ensures cases like rotate 0→360 are correctly detected as changes regardless of matrix equivalence.Test plan
Closes #21