IH-1262: Added firmwareVersion field to InstrumentDetailSummary f…#130
Open
rjoshi-hach wants to merge 3 commits into
Open
IH-1262: Added firmwareVersion field to InstrumentDetailSummary f…#130rjoshi-hach wants to merge 3 commits into
firmwareVersion field to InstrumentDetailSummary f…#130rjoshi-hach wants to merge 3 commits into
Conversation
…or tracking firmware manifest version of the instrument
rjoshi-hach
requested review from
AQI-DanG,
Abhijeet-2890,
MartinBenn-AI,
Copilot,
nitinpalewar-hach,
rsingh-hach,
skumar-hach,
surajndhach and
vkunuguntl
There was a problem hiding this comment.
Pull request overview
This PR updates package metadata and the changelog for a claimed firmwareVersion addition to InstrumentDetailSummary.
Changes:
- Bumps the C# package version prefix to
7.22.0. - Adds an
IH-1262version suffix. - Adds a changelog entry for the new
firmwareVersionfield.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/ONE.Models.CSharp/ONE.Models.CSharp.csproj |
Updates package version metadata. |
CHANGELOG.md |
Documents the claimed InstrumentDetailSummary.firmwareVersion addition. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
surajndhach
previously approved these changes
May 15, 2026
MartinBenn-AI
previously approved these changes
May 15, 2026
rsingh-hach
previously approved these changes
May 18, 2026
MatthewDeRose-AI
previously approved these changes
May 22, 2026
rjoshi-hach
dismissed stale reviews from MatthewDeRose-AI, rsingh-hach, MartinBenn-AI, and surajndhach
via
d49b1b4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR for ONE.Interfaces.ProtocolBuffers --> AquaticInformatics/ONE.Interfaces.ProtocolBuffers#130