Treewide: Remove python2 conditional logic/imports#1569
Open
Ryanf55 wants to merge 1 commit intoArduPilot:masterfrom
Open
Treewide: Remove python2 conditional logic/imports#1569Ryanf55 wants to merge 1 commit intoArduPilot:masterfrom
Ryanf55 wants to merge 1 commit intoArduPilot:masterfrom
Conversation
Signed-off-by: Ryan Friedman <25047695+Ryanf55@users.noreply.github.com>
564a5c3 to
1e30b72
Compare
peterbarker
requested changes
May 23, 2025
Contributor
peterbarker
left a comment
There was a problem hiding this comment.
Has to pass CI.
How was this tested?
Ryanf55
commented
May 23, 2025
| if prompt != self.prompt: | ||
| self.prompt = prompt | ||
| if platform.system() != 'Windows' or sys.version_info < (3, 0): | ||
| if platform.system() != 'Windows' or sys.version_info < (3, 0): #?? |
Contributor
Author
There was a problem hiding this comment.
Finish before merge
Contributor
Author
|
Here's a test plan based on the changes, I'll check off things as I go. I might request help on some of the modules like ntrip that I don't know how to use.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove conditional imports and conditional logic searching for
sys.version_infothat only apply to python2.Used ChatGTP with a grepped import list to find legacy python2 module logic too.