Skip to content

Fix duplicate upload notifications for collection track publishes #14031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
cursor wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fix duplicate upload notifications for collection track publishes #14031

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/common/src/adapters/track.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,6 +280,7 @@ export const trackMetadataForUploadToSdk = (
'is_download_gated',
'is_downloadable',
'is_original_available',
'is_playlist_upload',
'is_scheduled_release',
'bpm',
'is_custom_bpm',
Expand Down
2 changes: 2 additions & 0 deletions packages/common/src/api/tan-query/upload/usePublishCollection.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,6 +239,8 @@ function combineMetadata(
// Set download & hidden status
metadata.is_downloadable = !!collectionMetadata.is_downloadable

// Marks child tracks so backend suppresses per-track follower create notifications.
metadata.is_playlist_upload = true
metadata.is_unlisted = !!collectionMetadata.is_private
if (collectionMetadata.is_private && collectionMetadata.field_visibility) {
// Convert any undefined values to booleans
Expand Down
1 change: 1 addition & 0 deletions packages/sdk/src/sdk/api/tracks/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,7 @@ export const UploadTrackMetadataSchema = z.object({
coverArtSizes: z.optional(z.string()),
isDownloadable: z.optional(z.boolean()),
isOriginalAvailable: z.optional(z.boolean()),
isPlaylistUpload: z.optional(z.boolean()),
ddexReleaseIds: z.optional(z.record(z.string()).nullable()),
ddexApp: z.optional(z.string()).nullable(),
artists: z.optional(z.array(DDEXResourceContributor)).nullable(),
Expand Down
Loading