Gate Intercom launcher behind intercom_preview localStorage flag#988
Closed
ngnijland wants to merge 2 commits into
Closed
Gate Intercom launcher behind intercom_preview localStorage flag#988ngnijland wants to merge 2 commits into
ngnijland wants to merge 2 commits into
Conversation
Drop the intercom_preview localStorage gate so every visitor sees the Messenger launcher. Visitors arriving from teams.rocketsim.app with an identified Intercom session are still recognized automatically via the shared .rocketsim.app Messenger cookie — no identity boot is needed on this side. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Replaces the previous hide_default_launcher-only gate: non-preview
visitors now don't load the Intercom widget at all. Paired with the same
gate on teams.rocketsim.app so we can dogfood the cross-subdomain
identity handoff in production without exposing Messenger to every
visitor. Opt in via `localStorage.setItem("intercom_preview", "true")`.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/layouts/components/Intercom.astrobehind aintercom_previewlocalStorage check — replacing the previoushide_default_launcher-only gate so non-preview visitors don't load the widget at all.teams.rocketsim.app) so we can dogfood the cross-subdomain identified handoff in production without exposing Messenger to every visitor.localStorage.setItem("intercom_preview", "true"). Remove the item to opt out. Once we're happy with the flow, a follow-up PR will drop the gate on both sides.Paired change
Dashboard: https://github.com/AvdLee/LicenseKit/pull/670 — adds the verified-identity boot on
teams.rocketsim.app, gated on the same flag.Identified session lifetime
The cross-subdomain handoff is carried by Intercom's own cookies on
.rocketsim.app. Defaults:intercom-session-<app_id>intercom-id-<app_id>intercom-device-id-<app_id>Practically this means:
Test plan
rocketsim.appin a clean browser and confirm no Intercom script loads (no requests towidget.intercom.io).localStorage.setItem("intercom_preview", "true")in DevTools, reload, and confirm the Messenger launcher appears.teams.rocketsim.app, log in there, then return torocketsim.appand confirm the visitor is recognized as the identified user (not a fresh anonymous lead).localStorage.removeItem("intercom_preview"), reload, confirm Intercom disappears again.npm run lint && npm run format:check && npm run typecheck && npm run build && npm run knip— all pass locally.🤖 Generated with Claude Code