feat: merge-train/barretenberg #19653
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the missing `graph_description_keccak.test.cpp` for keccak in `boomerang_value_detection` module.
Updates the commit hash in blake files included in the blake audit scope document.
Collaborator
Author
|
🤖 Auto-merge enabled after 4 hours of inactivity. This PR will be merged automatically once all checks pass. |
## Summary - Enable `BB_ASSERT` macros in WASM builds for improved debugging and error detection - Add `BB_ASSERT_NO_WASM` family for performance-critical asserts that are too expensive to run in WASM - Convert two high-frequency asserts to NO_WASM variants (RefArray iterator at 159M hits, Polynomial::set_if_valid_index at 13.5M hits) - Convert `throw_or_abort` in recursion_constraint and public_input_component back to `BB_ASSERT` now that WASM asserts are enabled Closes AztecProtocol/barretenberg#1200 ## Benchmark Results ### ChonkBench (WASM Full/2) | Configuration | Time | Regression | |--------------|------|------------| | Baseline (asserts disabled) | 21,872 ms | - | | All asserts enabled | 22,480 ms | +2.8% | | With NO_WASM on hot asserts | 22,195 ms | +1.5% | ### AVM Bulk Test | Configuration | Proving Time | Bulk Test Time | |--------------|--------------|----------------| | Baseline (asserts disabled) | 29,303 ms | 29,889 ms | | With asserts enabled | 27,315 ms | 27,861 ms | No significant regression observed in AVM proving. The 1.5% regression in ChonkBench is an acceptable tradeoff for the improved debuggability and error detection that asserts provide in WASM builds. ## Test Plan - [x] WASM ChonkBench Full/2 and Full/5 benchmarks pass - [x] AVM bulk proving test passes (`avm_bulk.test.ts`) - [x] Native builds unaffected (NO_WASM macros expand to regular asserts)
This removes some unnecessary wrappers around the inputs to some blackbox functions
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Collaborator
Author
|
🤖 Auto-merge enabled after 4 hours of inactivity. This PR will be merged automatically once all checks pass. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Assert did not account for size_t = 32 bits in wasm and was overflowing
Changes include: - Introduce `apply_32_bit_range_constraint_via_lookup()` for efficient 32-bit range constraints - Change `add_normalize` --> `add_normalize_unsafe` to highlight lack of range constraint on output; add parameter `overflow_bits` - Reduce certain divisor/overflow range constraints from 3 to 2 or 1 to match max required for completeness - Remove all AUDITTODOs, some of which were erroneous
- Adds bigfield audit scope (already audited) - Adds logic module scope (to be audited with hash functions) - Adds `goblin_field` and `biggroup_goblin` in circuit builder scope - Deletes eccvm circuit/prover audit scope (included with eccvm core audit or chonk verifier)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
chore: add graph_description_keccak test (#19575)
chore: update commit hash in blake files in blake audit scope (#19593)
feat: enable asserts in WASM builds (#19632)
chore: remove unnecessary "inputs" structs (#19660)
fix: overflow in wasm assert (#19690)
chore!: sha audit 2 (#19436)
chore: add logic audit scope (and add old bigfield scope) (#19680)
END_COMMIT_OVERRIDE