chore: fast txs request bench#19673
Closed
mralj wants to merge 12 commits intomralj/feat/fast-tx-requestfrom
Closed
chore: fast txs request bench#19673mralj wants to merge 12 commits intomralj/feat/fast-tx-requestfrom
mralj wants to merge 12 commits intomralj/feat/fast-tx-requestfrom
Conversation
Collaborator
Flakey Tests🤖 says: This CI run detected 2 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
9ad4860 to
33e4abf
Compare
Adds fast tx request per this spec: #15149 Co-authored-by: danielntmd <danielntmd@nethermind.io>
fixed tests reqresp batch requester refactor proper benchmark output bugifx bench tx collection workers bugfixes bugfixes bugfixes refactor & bugfixes bugfixes refactor
1b09f98 to
e3d358a
Compare
Contributor
Author
|
I have messed up rebase, closing in favour of: #19849 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE:
batch-requester is the new one
While implementing benchmarks, I discovered a couple of bugs in the old reqreps batch requeter, which this PR also fixes. Without the fixes, the old code is basically useless.
REF: A-116