chore(avm)!: WIP - ecc pre-audit docs #19694
Draft
+400
−260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MirandaWood
commented
Jan 17, 2026
Comment on lines
-78
to
-84
| // Needs to be commited since we'll use it in the ecc add lookup for doubling | ||
| pol commit not_end; | ||
| // not_end = sel & !end | ||
| not_end - sel * (1 - end) = 0; | ||
|
|
||
| // Double check: sel = not_end | end | ||
| end + not_end - sel = 0; |
Contributor
Author
There was a problem hiding this comment.
Removed end + not_end - sel = 0; as I think this is ensured by the definition of sel_not_end and SELECTOR_ON_START_OR_END
MirandaWood
commented
Jan 17, 2026
Comment on lines
+166
to
169
| // TODO Hack for bb-pilcom to see shifted temp columns // TODO required? | ||
| temp_x' - temp_x' = 0; | ||
| temp_y' - temp_y' = 0; | ||
| temp_inf' - temp_inf' = 0; |
Contributor
Author
There was a problem hiding this comment.
Is this hack still needed? Removing it does indeed mean bb-pilcom ignores the shifted temp columns but I'm wondering if we can use a more permanent fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(WIP)
This branch is only low priority (no bug fixes or big logic changes) including:
Applies to AVM-72 and AVM-81.