Skip to content

Remove invalid product slug - #6

Open
Tong Xu (MSFT) (v-xuto) wants to merge 1 commit into
Azure-Samples:mainfrom
v-xuto:update-metadata
Open

Tong Xu (MSFT) (v-xuto) wants to merge 1 commit into
Azure-Samples:mainfrom
v-xuto:update-metadata

Conversation

@v-xuto

@v-xuto Tong Xu (MSFT) (v-xuto) commented Jun 19, 2024

Copy link
Copy Markdown
Contributor

Remove invalid products slug deployment-environments.

Wallace Breza (@wbreza) and Marina He (@hemarina) for notification.

@v-xuto Tong Xu (MSFT) (v-xuto) changed the title Remove invalid products Remove invalid product slug Jun 19, 2024
@v-xuto

Copy link
Copy Markdown
Contributor Author

Wallace Breza (@wbreza) Could you help review this PR? Thanks a lot.

Comment thread README.md
- bicep
products:
- azure
- deployment-environments

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for ADE (Azure Deployment Environments). What is invalid about it?

@hemarina Marina He (hemarina) Aug 14, 2024

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK - so should we move it into a services section then?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hemarina Marina He (hemarina) Aug 19, 2024

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wallace Breza (@wbreza) Moving to service section is not working as azure samples browse only have language and product filters. I suggest removing it for now so that this template will be on the samples. We could follow up on whether azure sample browser team plan to add service tag as a filter option, and this might take some time for them to decide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants