Skip to content

Regenerate initiatives.json to drop duplicate WAF-on-AppGw built-in#2172

Draft
pratyushverma63 with Copilot wants to merge 3 commits into
pratyverma4078_Duplicate_Policy_in_Enforce-Guardrails-Network_20250326from
copilot/fix-code-for-review-comment
Draft

Regenerate initiatives.json to drop duplicate WAF-on-AppGw built-in#2172
pratyushverma63 with Copilot wants to merge 3 commits into
pratyverma4078_Duplicate_Policy_in_Enforce-Guardrails-Network_20250326from
copilot/fix-code-for-review-comment

Conversation

Copilot AI commented Jul 14, 2026

Copy link
Copy Markdown

The source initiative Enforce-Guardrails-Network_20250326 was updated to remove the duplicate Deny-AppGw-Without-Waf reference (built-in 564feb30-..., already referenced as Deny-Waf-Fw-rules) and its now-unused appGwWaf parameter, but the generated deployment artifact was not rebuilt — leaving the removed content in the published template and failing the Pester check that validates it against source.

Changes

  • Regenerated eslzArm/managementGroupTemplates/policyDefinitions/initiatives.json from src/templates/initiatives.bicep:

    bicep build ./src/templates/initiatives.bicep \
      --outfile ./eslzArm/managementGroupTemplates/policyDefinitions/initiatives.json
    

The regenerated artifact no longer contains the appGwWaf parameter or the duplicate Deny-AppGw-Without-Waf policy reference. The only incidental delta is the _generator metadata (bicep version/hash), which Test-BuildPolicies strips via Remove-JSONMetadata before comparison.

Pratyush Verma (BEYONDSOFT CONSULTING INC) and others added 2 commits July 14, 2026 10:13
…drails-Network_20250326

The built-in policy 564feb30-bf6a-4854-b4bb-0d2d2d1e6c66 (WAF should be enabled for Application Gateway) was referenced twice in the initiative: as Deny-Waf-Fw-rules (param wafFwRules) and Deny-AppGw-Without-Waf (param appGwWaf). Removed the duplicate Deny-AppGw-Without-Waf reference and the now-unused appGwWaf parameter.
Copilot AI changed the title [WIP] Fix code based on review comment Regenerate initiatives.json to drop duplicate WAF-on-AppGw built-in Jul 14, 2026
Copilot AI requested a review from pratyushverma63 July 14, 2026 05:25

@pratyushverma63 pratyushverma63 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed

@pratyushverma63
pratyushverma63 force-pushed the pratyverma4078_Duplicate_Policy_in_Enforce-Guardrails-Network_20250326 branch from 0071a58 to 8ad7730 Compare July 14, 2026 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants