Skip to content

Check git staging failures in Update-VcpkgPort.ps1 #7362

Description

@j7nw4r

Summary

Both git add -A calls in eng/scripts/Update-VcpkgPort.ps1 lack immediate $LASTEXITCODE checks.

Motivation

This behavior exists on main and predates PR #7361. A staging failure is reported as a later commit failure.

Proposal

Check each staging command immediately. Emit a staging-specific error. Cover both temporary and final commit paths.

Found while reviewing #7361.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    EngSysThis issue is impacting the engineering system.bugThis issue requires a change to an existing behavior in the product in order to be resolved.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions