Skip to content

[AutoPR azure-resourcemanager-appcontainers]-generated-from-SDK Generation - Java-6788929 - #50343

Open
azure-sdk-automation[bot] wants to merge 10 commits into
mainfrom
sdkauto/azure-resourcemanager-appcontainers-6781849
Open

[AutoPR azure-resourcemanager-appcontainers]-generated-from-SDK Generation - Java-6788929#50343
azure-sdk-automation[bot] wants to merge 10 commits into
mainfrom
sdkauto/azure-resourcemanager-appcontainers-6781849

Conversation

@azure-sdk-automation

@azure-sdk-automation azure-sdk-automation Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Configurations: 'specification/app/resource-manager/Microsoft.App/ContainerApps/tspconfig.yaml', and CommitSHA: 'a6eb10836d18553358f0aee5f0573be5307255e4' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6788929 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://azsdk-releaseplan-dashboard-hveph5aqhhcfhtgu.westus-01.azurewebsites.net/?releaseplan=36380 Submitted by: vturecek@microsoft.com

Copilot AI lite review requested due to automatic review settings September 3, 2026 01:25
@azure-sdk-automation azure-sdk-automation Bot added the auto-release When merged to main, release pipelines for this PR's changed packages trigger automatically. label Sep 3, 2026
@github-actions github-actions Bot added the Mgmt This issue is related to a management-plane library. label Sep 3, 2026
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
35 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The release is being marked stable 1.3.0 while the 1.3.0 CHANGELOG documents breaking changes, which should be reconciled with semver/versioning policy before merge.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Auto-generated update for azure-resourcemanager-appcontainers based on TypeSpec generation, aligning the management SDK with the latest Microsoft.App/ContainerApps spec input and updating package metadata/versioning for a new release.

Changes:

  • Added TypeSpec source provenance (tsp-location.yaml) to track spec directory + commit.
  • Regenerated the management library code (headers/docs updated to “TypeSpec Code Generator”, module opens updated, models/impls refreshed).
  • Updated central versioning metadata to release azure-resourcemanager-appcontainers as 1.3.0.
File summaries
File Description
sdk/appcontainers/azure-resourcemanager-appcontainers/tsp-location.yaml Adds TypeSpec spec-repo provenance; additionalDirectories needs an explicit empty-list value.
sdk/appcontainers/azure-resourcemanager-appcontainers/src/main/java/module-info.java Adds opens for implementation.models for serialization/reflection use.
sdk/appcontainers/azure-resourcemanager-appcontainers/src/main/java/com/azure/resourcemanager/appcontainers/package-info.java Package JavaDoc updated; wording needs grammar/capitalization cleanup.
sdk/appcontainers/azure-resourcemanager-appcontainers/src/main/java/com/azure/resourcemanager/appcontainers/models/package-info.java Models package JavaDoc updated; wording needs grammar/capitalization cleanup.
sdk/appcontainers/azure-resourcemanager-appcontainers/src/main/java/com/azure/resourcemanager/appcontainers/implementation/package-info.java Implementation package JavaDoc updated; wording needs grammar/capitalization cleanup.
sdk/appcontainers/azure-resourcemanager-appcontainers/src/main/java/com/azure/resourcemanager/appcontainers/fluent/package-info.java Fluent package JavaDoc updated; wording needs grammar/capitalization cleanup.
sdk/appcontainers/azure-resourcemanager-appcontainers/src/main/java/com/azure/resourcemanager/appcontainers/fluent/models/package-info.java Fluent models package JavaDoc updated; wording needs grammar/capitalization cleanup.
sdk/appcontainers/azure-resourcemanager-appcontainers/src/main/java/com/azure/resourcemanager/appcontainers/models/ClientCredentialMethod.java Enum JavaDoc became generic; should be descriptive for consumers.
sdk/appcontainers/azure-resourcemanager-appcontainers/src/main/java/com/azure/resourcemanager/appcontainers/models/ConnectedEnvironmentStorage.java Parameter JavaDoc wording (“connectedEnvironment”) should be human-readable.
eng/versioning/version_client.txt Promotes package to stable 1.3.0; needs alignment with documented breaking changes/semver expectations.
Review details
  • Files reviewed: 141/1093 changed files
  • Comments generated: 9
  • Review effort level: Lite

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Comment thread eng/versioning/version_client.txt
@github-actions

This comment has been minimized.

@azure-sdk-automation azure-sdk-automation Bot changed the title [AutoPR azure-resourcemanager-appcontainers]-generated-from-SDK Generation - Java-6781849 [AutoPR azure-resourcemanager-appcontainers]-generated-from-SDK Generation - Java-6782000 Sep 3, 2026
@github-actions

This comment has been minimized.

@azure-sdk-automation azure-sdk-automation Bot changed the title [AutoPR azure-resourcemanager-appcontainers]-generated-from-SDK Generation - Java-6782000 [AutoPR azure-resourcemanager-appcontainers]-generated-from-SDK Generation - Java-6782266 Sep 3, 2026
@azure-sdk-automation azure-sdk-automation Bot changed the title [AutoPR azure-resourcemanager-appcontainers]-generated-from-SDK Generation - Java-6782266 [AutoPR azure-resourcemanager-appcontainers]-generated-from-SDK Generation - Java-6782355 Sep 3, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: a70eed3c-e81b-4805-a625-df541c027f27
@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Automated management AutoPR review

  • Head SHA: 7e4eda6827ba429c405b9381892caab34322c8a5
  • Package: azure-resourcemanager-appcontainers
  • Release type: stable
  • API version: 2026-07-01
  • CHANGELOG: 1.3.0 (2026-09-03)
  • Java changes reviewed: eligible non-generated Java changes in the synchronized range
  • Breaking changes: review-state concern not repeated after critic deduplication
  • Decision: no high-confidence concerns

Informational

  • [MGMT-API-VERSION] Carried forward — sdk/appcontainers/azure-resourcemanager-appcontainers/CHANGELOG.md, release 1.3.0 (2026-09-03), declares package API version 2026-07-01.

Automated management AutoPR review by Management AutoPR Review. Advisory only.

Automated management AutoPR review by Management AutoPR Review: https://github.com/Azure/azure-sdk-for-java/actions/runs/33720345227. Advisory only.

@azure-sdk-automation azure-sdk-automation Bot changed the title [AutoPR azure-resourcemanager-appcontainers]-generated-from-SDK Generation - Java-6782355 [AutoPR azure-resourcemanager-appcontainers]-generated-from-SDK Generation - Java-6783890 Sep 3, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: a70eed3c-e81b-4805-a625-df541c027f27
@azure-sdk-automation azure-sdk-automation Bot changed the title [AutoPR azure-resourcemanager-appcontainers]-generated-from-SDK Generation - Java-6783890 [AutoPR azure-resourcemanager-appcontainers]-generated-from-SDK Generation - Java-6788929 Sep 4, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The stable 1.3.0 release contains public API compatibility breaks relative to released 1.2.0, and Build Analyze fails RevAPI with breaksVersioningRules=true. Please resolve or mitigate the compatibility breaks, or use an appropriate major version with the required compatibility approval, then regenerate the SDK.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: eb11fde0-888a-4ec4-b9a5-6bffca75bfe4
@weidongxu-microsoft
Weidong Xu (weidongxu-microsoft) dismissed their stale review September 4, 2026 08:01

Retracted: this update follows the configuration-only re-approval path; revapi.skip=true has been restored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-release When merged to main, release pipelines for this PR's changed packages trigger automatically. Mgmt This issue is related to a management-plane library.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants