[AutoPR azure-resourcemanager-appcontainers]-generated-from-SDK Generation - Java-6788929 - #50343
Conversation
…tainerApps/tspconfig.yaml', and CommitSHA: '11a9847b20ecda089434861c47293d9e7c31917a' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6781849 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
|
Azure Pipelines: Successfully started running 1 pipeline(s). 35 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
There was a problem hiding this comment.
🟡 Changes recommended
The release is being marked stable 1.3.0 while the 1.3.0 CHANGELOG documents breaking changes, which should be reconciled with semver/versioning policy before merge.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Auto-generated update for azure-resourcemanager-appcontainers based on TypeSpec generation, aligning the management SDK with the latest Microsoft.App/ContainerApps spec input and updating package metadata/versioning for a new release.
Changes:
- Added TypeSpec source provenance (
tsp-location.yaml) to track spec directory + commit. - Regenerated the management library code (headers/docs updated to “TypeSpec Code Generator”, module
opensupdated, models/impls refreshed). - Updated central versioning metadata to release
azure-resourcemanager-appcontainersas1.3.0.
File summaries
| File | Description |
|---|---|
| sdk/appcontainers/azure-resourcemanager-appcontainers/tsp-location.yaml | Adds TypeSpec spec-repo provenance; additionalDirectories needs an explicit empty-list value. |
| sdk/appcontainers/azure-resourcemanager-appcontainers/src/main/java/module-info.java | Adds opens for implementation.models for serialization/reflection use. |
| sdk/appcontainers/azure-resourcemanager-appcontainers/src/main/java/com/azure/resourcemanager/appcontainers/package-info.java | Package JavaDoc updated; wording needs grammar/capitalization cleanup. |
| sdk/appcontainers/azure-resourcemanager-appcontainers/src/main/java/com/azure/resourcemanager/appcontainers/models/package-info.java | Models package JavaDoc updated; wording needs grammar/capitalization cleanup. |
| sdk/appcontainers/azure-resourcemanager-appcontainers/src/main/java/com/azure/resourcemanager/appcontainers/implementation/package-info.java | Implementation package JavaDoc updated; wording needs grammar/capitalization cleanup. |
| sdk/appcontainers/azure-resourcemanager-appcontainers/src/main/java/com/azure/resourcemanager/appcontainers/fluent/package-info.java | Fluent package JavaDoc updated; wording needs grammar/capitalization cleanup. |
| sdk/appcontainers/azure-resourcemanager-appcontainers/src/main/java/com/azure/resourcemanager/appcontainers/fluent/models/package-info.java | Fluent models package JavaDoc updated; wording needs grammar/capitalization cleanup. |
| sdk/appcontainers/azure-resourcemanager-appcontainers/src/main/java/com/azure/resourcemanager/appcontainers/models/ClientCredentialMethod.java | Enum JavaDoc became generic; should be descriptive for consumers. |
| sdk/appcontainers/azure-resourcemanager-appcontainers/src/main/java/com/azure/resourcemanager/appcontainers/models/ConnectedEnvironmentStorage.java | Parameter JavaDoc wording (“connectedEnvironment”) should be human-readable. |
| eng/versioning/version_client.txt | Promotes package to stable 1.3.0; needs alignment with documented breaking changes/semver expectations. |
Review details
- Files reviewed: 141/1093 changed files
- Comments generated: 9
- Review effort level: Lite
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
This comment has been minimized.
This comment has been minimized.
…tainerApps/tspconfig.yaml', and CommitSHA: '6df80ef77077563a304a20d3390ec69937753f42' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6782000 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
This comment has been minimized.
This comment has been minimized.
…tainerApps/tspconfig.yaml', and CommitSHA: 'cccc5d0c68c43997f4f45a9fe2b0959f4a894c47' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6782266 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
…tainerApps/tspconfig.yaml', and CommitSHA: 'cccc5d0c68c43997f4f45a9fe2b0959f4a894c47' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6782355 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a70eed3c-e81b-4805-a625-df541c027f27
Automated management AutoPR review
Informational
|
…tainerApps/tspconfig.yaml', and CommitSHA: '28f7a0806e501aa3dca466907688e08c7139f5ac' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6783890 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a70eed3c-e81b-4805-a625-df541c027f27
…tainerApps/tspconfig.yaml', and CommitSHA: 'a6eb10836d18553358f0aee5f0573be5307255e4' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6788929 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
Weidong Xu (weidongxu-microsoft)
left a comment
There was a problem hiding this comment.
The stable 1.3.0 release contains public API compatibility breaks relative to released 1.2.0, and Build Analyze fails RevAPI with breaksVersioningRules=true. Please resolve or mitigate the compatibility breaks, or use an appropriate major version with the required compatibility approval, then regenerate the SDK.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: eb11fde0-888a-4ec4-b9a5-6bffca75bfe4
Retracted: this update follows the configuration-only re-approval path; revapi.skip=true has been restored.
Configurations: 'specification/app/resource-manager/Microsoft.App/ContainerApps/tspconfig.yaml', and CommitSHA: 'a6eb10836d18553358f0aee5f0573be5307255e4' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6788929 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://azsdk-releaseplan-dashboard-hveph5aqhhcfhtgu.westus-01.azurewebsites.net/?releaseplan=36380 Submitted by: vturecek@microsoft.com