[AutoPR azure-iot-deviceregistry-softwareupdate]-generated-from-SDK Generation - Java-6787170 - #50358
Open
azure-sdk-automation[bot] wants to merge 1 commit into
Conversation
…ry/tspconfig.yaml', SDK Release Type: beta, and CommitSHA: 'ba93a8ee2aaf232c9029c2b8ddce411870faaf67' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6787170 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
|
Azure Pipelines: Successfully started running 1 pipeline(s). 35 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The deviceregistry CI path filters don’t include the new module directory and the new package’s release docs (CHANGELOG/README samples) need cleanup for release readiness.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR adds a new beta data-plane Java SDK module, azure-iot-deviceregistry-softwareupdate, generated from TypeSpec for the Software Update for Device Registry service, and wires it into the deviceregistry service directory build/release configuration.
Changes:
- Adds the new Maven module under
sdk/deviceregistry/and registers it for CI/release batching. - Introduces generated client, model, and implementation code for the Software Update for Device Registry API surface.
- Adds release metadata (README/CHANGELOG/assets/versioning entry) for SDK release readiness.
File summaries
| File | Description |
|---|---|
| sdk/deviceregistry/pom.xml | Adds the new azure-iot-deviceregistry-softwareupdate module to the deviceregistry aggregator build. |
| sdk/deviceregistry/ci.yml | Registers the new artifact for pipeline builds/releases (but needs trigger path filter update). |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/tsp-location.yaml | Records the TypeSpec/spec source location used for generation. |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/samples/java/com/azure/iot/deviceregistry/softwareupdate/ReadmeSamples.java | Provides README snippet source (was empty; comment added with suggested fix). |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/main/resources/META-INF/azure-iot-deviceregistry-softwareupdate_metadata.json | Generator metadata and cross-language mappings for the new library. |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/main/resources/azure-iot-deviceregistry-softwareupdate.properties | Build-time name/version properties consumed by the client builder. |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/main/java/module-info.java | Declares JPMS module exports/opens for the new library. |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/main/java/com/azure/iot/deviceregistry/softwareupdate/SoftwareUpdateClient.java | Generated synchronous client for software update operations. |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/main/java/com/azure/iot/deviceregistry/softwareupdate/package-info.java | Package-level documentation for the public client package. |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/main/java/com/azure/iot/deviceregistry/softwareupdate/models/UpdateOperation.java | Generated model for operation status payloads. |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/main/java/com/azure/iot/deviceregistry/softwareupdate/models/UpdateInfo.java | Generated model for update summary information. |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/main/java/com/azure/iot/deviceregistry/softwareupdate/models/UpdateId.java | Generated model for update identifiers. |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/main/java/com/azure/iot/deviceregistry/softwareupdate/models/UpdateFileDownloadHandler.java | Generated model for download handler metadata. |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/main/java/com/azure/iot/deviceregistry/softwareupdate/models/UpdateFileBase.java | Generated base model for update file metadata. |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/main/java/com/azure/iot/deviceregistry/softwareupdate/models/UpdateFile.java | Generated model for update file metadata details. |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/main/java/com/azure/iot/deviceregistry/softwareupdate/models/Update.java | Generated model for update metadata. |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/main/java/com/azure/iot/deviceregistry/softwareupdate/models/StepType.java | Generated expandable enum for install step types. |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/main/java/com/azure/iot/deviceregistry/softwareupdate/models/Step.java | Generated model for install instruction steps. |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/main/java/com/azure/iot/deviceregistry/softwareupdate/models/package-info.java | Package-level documentation for models. |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/main/java/com/azure/iot/deviceregistry/softwareupdate/models/OperationState.java | Generated expandable enum for LRO operation states. |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/main/java/com/azure/iot/deviceregistry/softwareupdate/models/Instructions.java | Generated model for instruction containers. |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/main/java/com/azure/iot/deviceregistry/softwareupdate/models/ImportUpdateRequest.java | Generated request model for importing an update. |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/main/java/com/azure/iot/deviceregistry/softwareupdate/models/ImportUpdateInputItem.java | Generated request model for import input items. |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/main/java/com/azure/iot/deviceregistry/softwareupdate/models/ImportManifestMetadata.java | Generated request model for import manifest metadata. |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/main/java/com/azure/iot/deviceregistry/softwareupdate/models/FileImportMetadata.java | Generated request model for file import metadata. |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/main/java/com/azure/iot/deviceregistry/softwareupdate/models/DeviceClassProperties.java | Generated model for device class properties. |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/main/java/com/azure/iot/deviceregistry/softwareupdate/models/DeviceClass.java | Generated model for device class entities. |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/main/java/com/azure/iot/deviceregistry/softwareupdate/models/Compatibility.java | Generated model for compatibility key/value pairs. |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/main/java/com/azure/iot/deviceregistry/softwareupdate/models/BestCompatibleUpdate.java | Generated model for best compatible update references. |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/main/java/com/azure/iot/deviceregistry/softwareupdate/implementation/package-info.java | Package-level documentation for implementation internals. |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/main/java/com/azure/iot/deviceregistry/softwareupdate/implementation/DeviceRegistrySoftwareUpdateClientImpl.java | Generated inner client wiring (pipeline/serializer/op groups). |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/main/java/com/azure/iot/deviceregistry/softwareupdate/implementation/DeviceClassesImpl.java | Generated REST proxy + paging helpers for device classes operations. |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/main/java/com/azure/iot/deviceregistry/softwareupdate/DeviceRegistrySoftwareUpdateServiceVersion.java | Defines supported service API versions. |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/main/java/com/azure/iot/deviceregistry/softwareupdate/DeviceRegistrySoftwareUpdateClientBuilder.java | Generated builder with pipeline/auth configuration. |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/main/java/com/azure/iot/deviceregistry/softwareupdate/DeviceClassesClient.java | Generated synchronous client for device class operations. |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/main/java/com/azure/iot/deviceregistry/softwareupdate/DeviceClassesAsyncClient.java | Generated async client for device class operations. |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/README.md | Package README (currently has an empty example block; comment added). |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/pom.xml | New package Maven configuration and dependencies. |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/CHANGELOG.md | New package changelog (needs cleanup; comment added). |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/assets.json | Release assets configuration for the new package. |
| eng/versioning/version_client.txt | Registers the new package version in repo-wide versioning. |
Review details
- Files reviewed: 42/43 changed files
- Comments generated: 4
- Review effort level: Lite
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+1
to
+12
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // Licensed under the MIT License. | ||
| // Code generated by Microsoft (R) TypeSpec Code Generator. | ||
|
|
||
| package com.azure.iot.deviceregistry.softwareupdate; | ||
|
|
||
| public final class ReadmeSamples { | ||
| public void readmeSamples() { | ||
| // BEGIN: com.azure.iot.deviceregistry.softwareupdate.readme | ||
| // END: com.azure.iot.deviceregistry.softwareupdate.readme | ||
| } | ||
| } |
Comment on lines
+37
to
+40
| - name: release_azureiotdeviceregistrysoftwareupdate | ||
| displayName: azure-iot-deviceregistry-softwareupdate | ||
| type: boolean | ||
| default: true |
Comment on lines
+3
to
+16
| ## 1.0.0-beta.1 (Unreleased) | ||
|
|
||
| - Azure DeviceRegistrySoftwareUpdateClient client library for Java. This package contains Microsoft Azure DeviceRegistrySoftwareUpdateClient client library. | ||
|
|
||
| ### Features Added | ||
|
|
||
| ### Breaking Changes | ||
|
|
||
| ### Bugs Fixed | ||
|
|
||
| ### Other Changes | ||
| ### Features Added | ||
|
|
||
| - Initial release for the azure-iot-deviceregistry-softwareupdate Java SDK. |
Comment on lines
+39
to
+43
| ## Examples | ||
|
|
||
| ```java com.azure.iot.deviceregistry.softwareupdate.readme | ||
| ``` | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Configurations: 'specification/deviceupdate/data-plane/sudeviceregistry/tspconfig.yaml', SDK Release Type: beta, and CommitSHA: 'ba93a8ee2aaf232c9029c2b8ddce411870faaf67' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6787170 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://azsdk-releaseplan-dashboard-hveph5aqhhcfhtgu.westus-01.azurewebsites.net/?releaseplan=36134 Submitted by: wuaustin@microsoft.com