Fix AAD authentication for RedTeam model_config in ACA environments #44622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Evaluation
slister1001
force-pushed
the
fix/aad-auth-token-credential
branch
from
88b8d82 to
9f4f637
Compare
Add support for TokenCredential in AzureOpenAIModelConfiguration to enable AAD authentication that works in Azure Container Apps (ACA) environments where DefaultAzureCredential doesn't have access to customer resources. Changes: - Add credential field to AzureOpenAIModelConfiguration TypedDict - Add _create_token_provider() to create callable token providers from TokenCredential objects (PyRIT's OpenAIChatTarget accepts api_key as either string or callable) - Update get_chat_target() to use credential when api_key not provided - Remove invalid api_version parameter from OpenAIChatTarget calls (PyRIT handles this via endpoint URL format) - Raise clear error when neither api_key nor credential is provided
slister1001
force-pushed
the
fix/aad-auth-token-credential
branch
from
9f4f637 to
abffbb4
Compare
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for TokenCredential in AzureOpenAIModelConfiguration to enable AAD authentication that works in Azure Container Apps (ACA) environments where DefaultAzureCredential doesn't have access to customer resources.
Changes:
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new API spec, a link to the pull request containing these API spec changes should be included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines