Add client state snapshot to chat client stopped events - #1047
Merged
xingsy97 (xingsy97) merged 4 commits intoAug 31, 2026
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 2836d2c8-08c4-47da-b9af-b5916c610245
xingsy97 (xingsy97)
enabled auto-merge (squash)
August 25, 2026 05:33
| client.on("stopped", () => { | ||
| console.log(`chat client for ${userId} stopped`); | ||
| client.on("stopped", (event) => { | ||
| console.log(`chat client for ${event.userId} stopped`); |
There was a problem hiding this comment.
why not directly using client.userId? why userId is the one identify a client?
Collaborator
Author
There was a problem hiding this comment.
client.userId is already cleaned in resetState() before this stopped is emitted, so I use this event to preserve the user identity.
There was a problem hiding this comment.
sounds a bit tricky, shall we reserve a client snapshot for this event?
Collaborator
Author
There was a problem hiding this comment.
updated
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 2836d2c8-08c4-47da-b9af-b5916c610245
xingsy97 (xingsy97)
changed the title
| * `stop()` was called or the underlying connection terminated. | ||
| */ | ||
| export interface OnStoppedArgs {} | ||
| export interface OnStoppedArgs { |
There was a problem hiding this comment.
how about a
export interface ChatClientSnapshot {
userId: string;
rooms: RoomInfo[];
}
export interface OnStoppedArgs {
previousState: ChatClientSnapshot;
}
incase there will be more properties related to stop itself added later, for example stop reason?
Collaborator
Author
There was a problem hiding this comment.
updated
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 2836d2c8-08c4-47da-b9af-b5916c610245
Liangying.Wei (vicancy)
approved these changes
Aug 31, 2026
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 2836d2c8-08c4-47da-b9af-b5916c610245
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include a snapshot of the client’s user ID and joined rooms in the
stoppedevent arguments.Fixes #902