Chat: Implement agent protocol - #919
Merged
Merged
Conversation
Zhenghui Yan (vwxyzh)
approved these changes
Aug 28, 2026
Member
Author
|
Copilot resolve the merge conflicts in this pull request |
Co-authored-by: bjqian <16233725+bjqian@users.noreply.github.com>
Contributor
Resolved the conflicts against current |
This was referenced Sep 3, 2026
Liangying.Wei (vicancy)
added a commit
that referenced
this pull request
Sep 3, 2026
@azure/web-pubsub-client was bumped 1.0.4 -> 1.1.0 in #919. Version 1.1.0 declares engines.node >=22.0.0, but the chat-client job pins Node 20.x, so `yarn install` aborts with an engine incompatibility before any build step runs. The job is path-gated on sdk/webpubsub-chat-client/**, so this stayed latent until a PR touched that path again. Verified locally on Node 22.20.0 by running the job's full step sequence: yarn install --frozen-lockfile, yarn build, yarn build:bundle, yarn extract-api (review/ unchanged) and yarn test:unit (8/8 passing). Node 20 is EOL and the main JavaScript job already runs 22.x, so this also aligns the two. sdk/webpubsub-chat-client/package.json keeps engines.node >=20.0.0, which Node 22 satisfies; narrowing the published package's supported range is a separate decision. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: bf666f99-8d30-4763-878d-b566c0ac2f2d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Client decoding flow :
https://github.com/devdiv-azure-service-dmitryr/azure-signalr-specs/blob/biqian/agent/specs/chat/agent_impl.MD#client-view