Create Entities in-memory from Autoentities by RubenCerna2079 · Pull Request #3129 · Azure/data-api-builder

RubenCerna2079 · 2026-02-13T00:35:36Z

Why make this change?

Create entities in-memory from autoentities #3052
We need to generate all the entities from the autoentities properties. In order to do this we need to use the query that was previously created and, add the newly generated entities into the runtime so the user can use them.

What is this change?

MsSqlMetadataProvider.cs: Finish creating the GenerateAutoentitiesIntoEntities function so that it uses the query to receive all of the tables and turn them into entities inside the runtimeConfig.
RuntimeConfig.cs: Create new function that adds the new entities to the runtimeConfig. And also change the runtimeConfig to allow for the entities property to be missing if the user decides to use the autoentities property.

How was this tested?

Integration Tests
Unit Tests

azure-pipelines · 2026-02-13T18:41:00Z

Azure Pipelines successfully started running 6 pipeline(s).

src/Core/Services/MetadataProviders/MsSqlMetadataProvider.cs

src/Core/Configurations/RuntimeConfigProvider.cs

src/Config/ObjectModel/RuntimeConfig.cs

src/Service/Startup.cs

src/Service.Tests/Configuration/ConfigurationTests.cs

src/Core/Services/MetadataProviders/SqlMetadataProvider.cs

…-autoentities

RubenCerna2079 · 2026-02-17T19:51:45Z

/azp run

azure-pipelines · 2026-02-17T19:52:11Z

Azure Pipelines successfully started running 6 pipeline(s).

…-autoentities

RubenCerna2079 · 2026-02-18T05:33:16Z

/azp run

azure-pipelines · 2026-02-18T05:33:38Z

Azure Pipelines successfully started running 6 pipeline(s).

src/Config/ObjectModel/RuntimeConfig.cs

…-autoentities

RubenCerna2079 · 2026-02-20T19:44:16Z

/azp run

azure-pipelines · 2026-02-20T19:44:42Z

Azure Pipelines successfully started running 6 pipeline(s).

Aniruddh25 · 2026-02-20T21:28:19Z

src/Config/ObjectModel/RuntimeConfig.cs


        _entityNameToDataSourceName = new Dictionary<string, string>();
-        if (Entities is null)
+        if (Entities is null && this.Entities.Entities.Count == 0 &&


This condition will throw NullException

I am not following why this would throw a NullException

please rename Entities to entities since its a function argument

src/Config/ObjectModel/RuntimeConfig.cs

Aniruddh25 · 2026-02-20T22:38:12Z

src/Config/ObjectModel/RuntimeConfig.cs

+        return _entityNameToDataSourceName.TryAdd(entityName, this.DefaultDataSourceName);
+    }
+
+    public bool TryAddEntityNameToDataSourceName(string entityName, string autoEntityDefinition)


nit: rename the function to inform we are adding entity name from AutoentityDefinition

Aniruddh25 · 2026-02-20T22:53:31Z

src/Config/ObjectModel/RuntimeConfig.cs

+    /// <returns>DataSourceName</returns>
+    public string GetDataSourceNameFromAutoentityName(string autoentityName)
+    {
+        CheckAutoentityNamePresent(autoentityName);


instead of 2 functions, why cant we use TryGet function? if false, you can throw exception.

Aniruddh25 · 2026-02-20T23:03:57Z

src/Core/Services/MetadataProviders/MsSqlMetadataProvider.cs

        {
-            await Task.CompletedTask;
+            RuntimeConfig runtimeConfig = _runtimeConfigProvider.GetConfig();
+            Dictionary<string, Entity> entities = new();


define entities where its needed. Since autoentities could still be null, defining here is pre-mature if we are just going to return.

Aniruddh25 · 2026-02-20T23:08:21Z

src/Core/Services/MetadataProviders/MsSqlMetadataProvider.cs

+
+                    if (runtimeConfig.IsRestEnabled)
+                    {
+                        _logger.LogInformation("[{entity}] REST path: {globalRestPath}/{entityRestPath}", entityName, runtimeConfig.RestPath, entityName);


Why is only Rest information being logged?

Aniruddh25 · 2026-02-20T23:10:13Z

src/Core/Services/MetadataProviders/MsSqlMetadataProvider.cs

+            foreach ((string autoentityName, Autoentity autoentity) in autoentities)
+            {
+                int addedEntities = 0;
+                JsonArray? resultArray = await QueryAutoentitiesAsync(autoentity);


when querying, are we asking the right datasource to query from? How is that information being passed to QueryAutoentitiesAsync?

Aniruddh25 · 2026-02-20T23:34:26Z

src/Core/Services/MetadataProviders/SqlMetadataProvider.cs

            if (GetDatabaseType() == DatabaseType.MSSQL)
            {
-                await GenerateAutoentitiesIntoEntities();
+                await GenerateAutoentitiesIntoEntities(new Dictionary<string, Autoentity>(Autoentities));


why is the need to create new dictionary of Autoentities here? cant you simply pass the Readonly dictionary?

Aniruddh25 · 2026-02-20T23:46:35Z

src/Service.Tests/Configuration/RuntimeConfigLoaderTests.cs

+
+        Assert.IsTrue(loader.TryLoadConfig("dab-config.json", out RuntimeConfig runtimeConfig), "Should successfully load config");
+        Assert.IsTrue(runtimeConfig.SqlDataSourceUsed, "Should have Sql data source");
+        Assert.AreEqual(expectedEntities, runtimeConfig.Entities.Entities.Count, "Default datasource should be of root file database type.");


The error message here seems to be not accurate.

Aniruddh25 · 2026-02-20T23:47:53Z

src/Service.Tests/Multidab-config.MsSql.json

    "stocks_view_selected": {
      "source": {
        "object": "stocks_view_selected",
        "type": "view",


Can you also test by naming the child data sources explicitly? I dont know if we provide the datasource name in the sample files or rely on the default one.

Aniruddh25 · 2026-02-20T23:52:43Z

src/Service.Tests/Configuration/RuntimeConfigLoaderTests.cs

+
+        Assert.IsTrue(loader.TryLoadConfig("dab-config.json", out RuntimeConfig runtimeConfig), "Should successfully load config");
+        Assert.IsTrue(runtimeConfig.SqlDataSourceUsed, "Should have Sql data source");
+        Assert.AreEqual(expectedEntities, runtimeConfig.Entities.Entities.Count, "Default datasource should be of root file database type.");


does this runtimeConfig.Entities.Entities.Count include entities matching from all the data source files - including the ones that matched from autoentities ?

Aniruddh25

Waiting on addressing some questions..

RubenCerna2079 added this to the Feb 2026 milestone Feb 13, 2026

RubenCerna2079 self-assigned this Feb 13, 2026

RubenCerna2079 added the 2.0 label Feb 13, 2026

RubenCerna2079 added this to Data API builder Feb 13, 2026

github-project-automation bot moved this to Todo in Data API builder Feb 13, 2026

RubenCerna2079 linked an issue Feb 13, 2026 that may be closed by this pull request

Create entities in-memory from autoentities #3052

Open

RubenCerna2079 added 13 commits February 12, 2026 16:43

Changes for autoentities

a9a4ea0

Add query and its execution

4acee5c

Add testing

67e10d7

Changes based on comments

5453cbc

Changes based on comments

8fbea75

Added changes based on comments

cf4debf

Comment out failing section

88b8c66

Fix test failures

612d4bd

Fix formatting issues

a396fab

Generate in-memory entities

c8ed0d5

Changes to generate autoentities as entities

947fdec

Add new testing

e5ae16a

Add check so that either entities or autoentities is required

2f256e4

RubenCerna2079 force-pushed the dev/rubencerna/create-inmemory-entities-from-autoentities branch from 1972a8f to 2f256e4 Compare February 13, 2026 00:52

RubenCerna2079 marked this pull request as ready for review February 13, 2026 01:13

RubenCerna2079 requested a review from Aniruddh25 as a code owner February 13, 2026 01:13

Copilot AI review requested due to automatic review settings February 13, 2026 01:13

RubenCerna2079 requested review from Alekhya-Polavarapu, aaronburtle, anushakolan, neeraj-sharma2592, sourabh1007, souvikghosh04 and vadeveka as code owners February 13, 2026 01:13

Changes to fix tests

ba070db

JerryNixon approved these changes Feb 16, 2026

View reviewed changes

RubenCerna2079 and others added 2 commits February 17, 2026 11:50

Changes based on comments

5bd10a9

Merge branch 'main' into dev/rubencerna/create-inmemory-entities-from…

33f33c3

…-autoentities

Fix bug

83d706f

RubenCerna2079 requested a review from stuartpa as a code owner February 18, 2026 05:30

Merge branch 'main' into dev/rubencerna/create-inmemory-entities-from…

9ab35a6

…-autoentities

Aniruddh25 reviewed Feb 20, 2026

View reviewed changes

src/Config/ObjectModel/RuntimeConfig.cs Outdated Show resolved Hide resolved

RubenCerna2079 and others added 2 commits February 20, 2026 11:43

Changes to ensure autoentities work with multiple data sources

4a743c7

Merge branch 'main' into dev/rubencerna/create-inmemory-entities-from…

7570931

…-autoentities

Aniruddh25 reviewed Feb 20, 2026

View reviewed changes

src/Config/ObjectModel/RuntimeConfig.cs Show resolved Hide resolved

Aniruddh25 reviewed Feb 20, 2026

View reviewed changes

Aniruddh25 requested changes Feb 20, 2026

View reviewed changes

github-project-automation bot moved this from Todo to Review In Progress in Data API builder Feb 20, 2026

Comments

Conversation

RubenCerna2079 commented Feb 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why make this change?

What is this change?

How was this tested?

Uh oh!

azure-pipelines bot commented Feb 13, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

RubenCerna2079 commented Feb 17, 2026

Uh oh!

azure-pipelines bot commented Feb 17, 2026

Uh oh!

RubenCerna2079 commented Feb 18, 2026

Uh oh!

azure-pipelines bot commented Feb 18, 2026

Uh oh!

Uh oh!

RubenCerna2079 commented Feb 20, 2026

Uh oh!

azure-pipelines bot commented Feb 20, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Aniruddh25 Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Aniruddh25 Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Aniruddh25 Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Aniruddh25 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

RubenCerna2079 commented Feb 13, 2026 •

edited

Loading

Aniruddh25 Feb 20, 2026 •

edited

Loading

Aniruddh25 Feb 20, 2026 •

edited

Loading

Aniruddh25 Feb 20, 2026 •

edited

Loading