Fix Serialization/Deserialization issue with $ prefix columns (#3051)#3137
Merged
Aniruddh25 merged 2 commits intorelease/1.7from Feb 20, 2026
Merged
Fix Serialization/Deserialization issue with $ prefix columns (#3051)#3137Aniruddh25 merged 2 commits intorelease/1.7from
Aniruddh25 merged 2 commits intorelease/1.7from
Conversation
## Why make this change? Serialization and deserialization of metadata currently fail when column names are prefixed with the $ symbol. ## What is this change? This pull request enhances the serialization and deserialization logic for database metadata objects to properly handle column names that start with a dollar sign ($). It introduces a mechanism to escape such column names during serialization and unescape them during deserialization, ensuring compatibility and correctness when processing metadata with special column names. ## How was this tested? - [x] Unit Tests Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Alekhya-Polavarapu
requested review from
Aniruddh25,
RubenCerna2079,
aaronburtle,
anushakolan,
neeraj-sharma2592,
rusamant,
sourabh1007,
souvikghosh04 and
vadeveka
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request addresses serialization and deserialization issues when database column names start with a dollar sign (
Changes:
- Modified
DatabaseObjectConverterto escape/unescape column names starting with $ in theColumnsdictionary - Added three new test methods to verify serialization/deserialization with dollar-prefixed columns for DatabaseTable, DatabaseView, and DatabaseStoredProcedure
- Updated
InitializeObjectsmethod to support parameterized column name generation for testing
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 9 comments.
| File | Description |
|---|---|
| src/Core/Services/MetadataProviders/Converters/DatabaseObjectConverter.cs | Implements escape/unescape logic for dollar-prefixed column names in SourceDefinition.Columns dictionary |
| src/Service.Tests/UnitTests/SerializationDeserializationTests.cs | Adds test coverage for dollar-prefixed columns and parameterizes test object initialization |
src/Core/Services/MetadataProviders/Converters/DatabaseObjectConverter.cs
Show resolved
Hide resolved
src/Core/Services/MetadataProviders/Converters/DatabaseObjectConverter.cs
Show resolved
Hide resolved
src/Core/Services/MetadataProviders/Converters/DatabaseObjectConverter.cs
Show resolved
Hide resolved
src/Core/Services/MetadataProviders/Converters/DatabaseObjectConverter.cs
Show resolved
Hide resolved
Aniruddh25
approved these changes
Feb 17, 2026
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
RubenCerna2079
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why make this change?
Serialization and deserialization of metadata currently fail when column names are prefixed with the $ symbol.
What is this change?
This pull request enhances the serialization and deserialization logic for database metadata objects to properly handle column names that start with a dollar sign ($). It introduces a mechanism to escape such column names during serialization and unescape them during deserialization, ensuring compatibility and correctness when processing metadata with special column names.
How was this tested?