Add SP OBO Graph overage claim resolution support - #20
Open
hamm-bit wants to merge 11 commits into
Open
Conversation
Collaborator
|
per discussion, please impl different path for user and sp in akstokenprovider side #Closed |
added 5 commits
August 20, 2026 20:18
hamm-bit
force-pushed
the
add-sp-overage-resolution
branch
from
August 20, 2026 10:51
0c97fb1 to
c51043e
Compare
Bin Xia (bingosummer)
approved these changes
Aug 21, 2026
Bin Xia (bingosummer)
requested changes
Aug 21, 2026
Bin Xia (bingosummer)
approved these changes
Aug 25, 2026
| // transport error and the message is discarded. We need this error | ||
| // to surface in API server logs so operators can diagnose why the | ||
| // SPN authentication was rejected. | ||
| if isAppToken(claims) { |
Collaborator
There was a problem hiding this comment.
instead of removing it, can add a flag to support sp, and use that flag to control the logic?
later the flag can be removed #Closed
| } | ||
| resp.Groups, err = s.graphClient.GetGroups(ctx, resp.Username, token) | ||
| principal := resp.Username | ||
| isServicePrincipal := s.Options.EnableSPGroupResolution && isAppToken(claims) |
Collaborator
There was a problem hiding this comment.
isServicePrincipal := isAppToken(claims) ? makes more sense?
it could be computed once, and reused later for isAppToken check
also by here, no need to check EnableSPGroupResolution again? #Closed
Collaborator
There was a problem hiding this comment.
logically if ResolveGroupMembershipOnlyOnOverageClaim true, EnableSPGroupResolution already checked
if false, it no harm to do real sp path.
Dong Liu (karataliu)
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently guard only supports user principals overage resolution and places a hard block on SP overage. This commit adds support for Service Principals On-Behalf-Of flow.