[Breaking Change Guarded by a Flag] fix: restore CSR nodeclient DataAction granularity - #28
Open
Wei Weng (weng271190436) wants to merge 1 commit into
Conversation
Wei Weng (weng271190436)
force-pushed
the
weiweng/fix-csr-subresource-action-collapse
branch
2 times, most recently
from
August 27, 2026 14:36
817d2d2 to
023147f
Compare
Wei Weng (weng271190436)
force-pushed
the
weiweng/fix-csr-subresource-action-collapse
branch
from
August 27, 2026 14:51
023147f to
d40d4a2
Compare
Wei Weng (weng271190436)
changed the title
Wei Weng (weng271190436)
marked this pull request as ready for review
August 27, 2026 15:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reintroduces the security fix from #12 after its temporary rollback in #23, using Guard's current sensitive-subresource mapping framework.
Kubernetes authorizes kubelet client CSR auto-approval through the virtual
certificatesigningrequests/nodeclientsubresource. Guard currently collapses this request into the broadercertificatesigningrequests/writeDataAction.This PR adds the dedicated mapping behind a default-off compatibility flag:
--azure.enforce-csr-nodeclient-data-action=falseWhen enabled, Guard maps the request to:
certificates.k8s.io/certificatesigningrequests/nodeclient/actionWhen disabled, Guard preserves the current
certificatesigningrequests/writemapping. This allows the Guard image to ship before enforcement and provides an immediate rollback switch without requiring an image rollback.