Skip to content

Skip test builds in the non-runnable ARM64 mwin32 SDK job#176

Draft
Copilot wants to merge 2 commits into
mainfrom
copilot/fix-github-actions-job-failure
Draft

Skip test builds in the non-runnable ARM64 mwin32 SDK job#176
Copilot wants to merge 2 commits into
mainfrom
copilot/fix-github-actions-job-failure

Conversation

Copilot AI commented Jun 20, 2026

Copy link
Copy Markdown

The mwin32 SDK ARM64 Actions job was failing in the build phase because it cross-compiled test executables and then hit GoogleTest discovery, which attempts to execute them on the x64 runner. This change keeps the x64 SDK build/test behavior intact while preventing the ARM64 artifact job from building non-runnable tests.

  • Workflow matrix

    • Add a per-arch build_testing setting to the mwin32-sdk.yml matrix.
    • Keep BUILD_TESTING enabled for x64.
    • Disable BUILD_TESTING for arm64, which already has can_run_tests: false.
  • CMake configuration

    • Replace the unconditional test build flag with the matrix-driven value during configure.
    • This removes the mismatch where the workflow skipped the test step for ARM64 but still asked CMake to build and discover tests.
  • Resulting behavior

    • x64: unchanged; builds with tests and runs the in-scope mwin32 suite.
    • arm64: builds only the SDK artifacts needed for packaging; no test discovery is triggered during build.
matrix:
  include:
    - arch: x64
      can_run_tests: true
      build_testing: "ON"
    - arch: arm64
      can_run_tests: false
      build_testing: "OFF"

# ...
-D BUILD_TESTING=${{ matrix.build_testing }}

Copilot AI changed the title [WIP] Fix the failing GitHub Actions job build (arm64, ARM64, arm64-windows, false) Skip test builds in the non-runnable ARM64 mwin32 SDK job Jun 20, 2026
Copilot AI requested a review from EmJayGee June 20, 2026 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants