Skip to content

Conversation

@KYM-P
Copy link
Collaborator

@KYM-P KYM-P commented Jan 1, 2026

PR 개요

이슈 번호: #1197

PR 체크리스트

  • Code convention을 잘 지켰나요?
  • Lint check를 수행하였나요?
  • Assignees를 추가했나요?

작업사항

  • 버그 수정
  • 신규 기능
  • 코드 스타일 수정 (포맷팅 등)
  • 리팩토링 (기능 수정 X, API 수정 X)
  • 기타

작업사항의 상세한 설명

비상수화 완료 항목

auth

  • Aritcle
  • Cart
  • Chat
  • Club
  • Owner
  • Store
  • Timetable
  • User

non-auth

  • Article
  • Banner
  • Bus
  • Chat
  • Club
  • CoopShop
  • Dept
  • Dining
  • Land
  • OrderShop
  • PreSigned
  • Timetable
  • Upload
  • Version

비상수화 미완료 항목

auth

  • User

non-auth

  • Owner
  • Store
  • User

논의 사항

스크린샷

추가내용

  • develop, sprint 브랜치를 향하고 있습니다
  • production 브랜치를 향하고 있습니다

KYM-P added 23 commits December 29, 2025 02:02
This reverts commit 73c3cce.

# Conflicts:
#	data/src/main/java/in/koreatech/koin/data/api/StoreApi.kt
This reverts commit 3378342.

# Conflicts:
#	data/src/main/java/in/koreatech/koin/data/constant/URLConstant.kt
This reverts commit 37fdb91.

# Conflicts:
#	data/src/main/java/in/koreatech/koin/data/api/ClubApi.kt
#	data/src/main/java/in/koreatech/koin/data/api/auth/ClubAuthApi.kt
This reverts commit be50f6e.

# Conflicts:
#	data/src/main/java/in/koreatech/koin/data/api/ClubApi.kt
#	data/src/main/java/in/koreatech/koin/data/api/auth/ClubAuthApi.kt
#	data/src/main/java/in/koreatech/koin/data/constant/URLConstant.kt
This reverts commit e86010b.

# Conflicts:
#	data/src/main/java/in/koreatech/koin/data/constant/URLConstant.kt
@KYM-P KYM-P self-assigned this Jan 1, 2026
@KYM-P KYM-P requested a review from a team as a code owner January 1, 2026 07:38
@github-actions github-actions bot added refactor Code refactoring koin project labels Jan 1, 2026
Copy link
Member

@kongwoojin kongwoojin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
이 귀찮은걸 다 하셨군요...

.gitignore Outdated
# Replacement of .externalNativeBuild directories introduced
# with Android Studio 3.5.
.cxx/
KOIN_ANDROID_DESIGNSYSTEM/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

엥? 이건 뭔가요

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아 디자인 시스템 서브모듈 추가하면서 ignore 임시 수정했었는데 이게 들어갔네요
바아로 빼겠습니다.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

koin project refactor Code refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants